Follows up on #63035, which added ForegroundWorkSummary and a private DurationHistogram wrapper (histogram + exact total_nanos) to report GPUI's foreground journal timings through BenchReport::foreground_work(). Anthony pointed out the exact-total convenience did not justify the extra types, especially since GPUI already exposes hdrhistogram::Histogram directly elsewhere (e.g. profiler::FrameDurationSnapshot, profiler::InputLatencySnapshot). BenchReport::foreground_work() now returns a cloned hdrhistogram::Histogram<u64> of recorded nanosecond durations directly, instead of Option<ForegroundWorkSummary>. Empty work is an empty histogram rather than None. Callers get is_empty/len/max/value_at_quantile/iteration directly, with no RefCell borrow held. The internal WindowFrameSnapshot field switches from the private DurationHistogram wrapper to a plain Histogram<u64>, and the printed report drops the previously side-tracked exact total (which required the wrapper) rather than replace it with a less precise substitute; mean/percentiles/max/frame-budget overruns are still computed straight from the histogram the same way the other frame histograms already do. Testing: - cargo nextest run -p gpui --features bench --lib bench_context (4/4 pass, updated to assert directly on the returned histogram) - cargo nextest run -p gpui --features bench --lib profiler (48/48 pass, unchanged) - cargo check -p benchmarks --benches (existing #[gpui::bench] consumers still compile) - cargo fmt --package gpui -- --check and ./script/clippy -p gpui --features bench are clean |
||
|---|---|---|
| .agents/skills | ||
| .cargo | ||
| .cloudflare | ||
| .config | ||
| .factory | ||
| .github | ||
| .wezel | ||
| .zed | ||
| assets | ||
| ci | ||
| crates | ||
| docs | ||
| extensions | ||
| legal | ||
| nix | ||
| script | ||
| tooling | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .prettierrc | ||
| .rules | ||
| AGENTS.md | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CLAUDE.md | ||
| clippy.toml | ||
| CODE_OF_CONDUCT.md | ||
| compose.yml | ||
| CONTRIBUTING.md | ||
| debug.plist | ||
| default.nix | ||
| Dockerfile-collab | ||
| Dockerfile-collab.dockerignore | ||
| Dockerfile-cross.dockerignore | ||
| Dockerfile-distros | ||
| Dockerfile-distros.dockerignore | ||
| flake.lock | ||
| flake.nix | ||
| GEMINI.md | ||
| LICENSE-APACHE | ||
| LICENSE-GPL | ||
| livekit.yaml | ||
| lychee.toml | ||
| Procfile | ||
| Procfile.web | ||
| README.md | ||
| renovate.json | ||
| REVIEWERS.conl | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| shell.nix | ||
| typos.toml | ||
Important
Remove this line to confirm you've reviewed this PR before submitting.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.