Enabling gpui's `bench` feature previously enabled `test-support` too, so every `#[gpui::bench]` consumer transitively compiled gpui's interactive test-double APIs (fake platform prompts, screen capture simulation, proptest, etc.) alongside its production code. That defeats the point of a benchmark: it can silently depend on behavior that only exists for tests and would never ship. `bench` still needs a handful of pieces that used to arrive bundled inside `test-support`: a real multithreaded dispatcher (`ThreadedDispatcher`), a window backed by a real headless GPU renderer (`TestPlatform`/`TestWindow`/`PlatformHeadlessRenderer`), and the sprite atlas plumbing those use. Those are moved onto their own `cfg(any(test, feature = "test-support", feature = "bench"))` gates so `bench` can use them without pulling in `test-support` as a whole. The remaining interactive-only surface of `TestPlatform` (multiple-choice prompts, path-selection dialogs, and their simulate/inspect helpers) stays behind `test`/`test-support` only, since benchmarks have no API to answer a prompt; `bench`-only builds get a minimal stub that resolves such a prompt as immediately cancelled instead of leaving it pending. crates/benchmarks continues to compile unchanged: it separately requests `test-support` on `gpui_platform` (for its own real headless Metal renderer lookup), so gpui's feature graph still unifies to `bench + test-support` there today. That's a distinct dependency edge this change doesn't touch: `gpui_platform`, `gpui_macos`, and `gpui_apple` each gate their own headless-renderer glue behind their own test-support feature, and giving `#[gpui::bench]` a real end-to-end path that needs no crate's test-support would mean mirroring this same split there. Added script/check-gpui-bench-feature-isolation, which walks gpui's resolved feature graph with only `bench` enabled and fails if `test-support` reappears in it. Release Notes: - N/A |
||
|---|---|---|
| .agents/skills | ||
| .cargo | ||
| .cloudflare | ||
| .config | ||
| .factory | ||
| .github | ||
| .wezel | ||
| .zed | ||
| assets | ||
| ci | ||
| crates | ||
| docs | ||
| extensions | ||
| legal | ||
| nix | ||
| script | ||
| tooling | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .prettierrc | ||
| .rules | ||
| AGENTS.md | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CLAUDE.md | ||
| clippy.toml | ||
| CODE_OF_CONDUCT.md | ||
| compose.yml | ||
| CONTRIBUTING.md | ||
| debug.plist | ||
| default.nix | ||
| Dockerfile-collab | ||
| Dockerfile-collab.dockerignore | ||
| Dockerfile-cross.dockerignore | ||
| Dockerfile-distros | ||
| Dockerfile-distros.dockerignore | ||
| flake.lock | ||
| flake.nix | ||
| GEMINI.md | ||
| LICENSE-APACHE | ||
| LICENSE-GPL | ||
| livekit.yaml | ||
| lychee.toml | ||
| Procfile | ||
| Procfile.web | ||
| README.md | ||
| renovate.json | ||
| REVIEWERS.conl | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| shell.nix | ||
| typos.toml | ||
Important
Remove this line to confirm you've reviewed this PR before submitting.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.