vrr/vpnhide
2
0
Fork 0
mirror of https://github.com/okhsunrog/vpnhide.git synced 2026-05-19 16:13:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ci: drop the broken uniffi-bindgen pre-install from CI image

Browse source 
#106 added \`cargo install uniffi-bindgen --version "^0.29" --locked\`
to the CI image, expecting that this would let Gobley's
\`:app:installUniffiBindgen\` task find the binary ready and skip its
own ~50 s install. Two things were wrong with that:

1. crates.io has no \`uniffi-bindgen\` crate at version 0.29.x — Gobley
   actually installs \`gobley-uniffi-bindgen\` 0.3.7 (its own fork).
   The cargo install command failed with "could not find
   \`uniffi-bindgen\` in registry crates-io with version \`^0.29\`",
   killing the whole ci-image rebuild.
2. Even with the right package name, Gobley installs the binary into
   \`app/build/gobley-tools-install/uniffi-bindgen/\` (its task-local
   output dir), not \`~/.cargo/bin\`. A globally pre-installed binary
   wouldn't satisfy the task's UP-TO-DATE check.

The good news: \`org.gradle.caching=true\` in \`lsposed/gradle.properties\`
(also in #106) already makes \`installUniffiBindgen\` go UP-TO-DATE on
warm builds via Gradle's build cache — verified locally with
\`./gradlew :app:lintDebug\` showing 17/40 tasks up-to-date after the
first run. So the optimisation that #106 was reaching for is in
effect, just delivered through the build cache rather than the image.

This commit removes only the broken cargo-install line. The other
changes from #106 (build/configuration cache, lint trim, lintDebug)
stay in.
This commit is contained in:
okhsunrog 2026-04-27 00:39:11 +03:00
parent 005a54a55f
commit 8df92f0e6f
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.github/docker/ci/Dockerfile vendored
View file

@ -53,11 +53,6 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | \
rustup target add aarch64-linux-android && \
rustup component add rustfmt clippy && \
cargo install cargo-ndk --locked && \
# Pre-built uniffi-bindgen so Gobley's :app:installUniffiBindgen task
# finds it ready (instead of running `cargo install uniffi-bindgen` on
# every CI build — that took ~50 s of the lsposed/lint job each run).
# Version range matches lsposed/native/Cargo.toml's `uniffi = "0.29"`.
cargo install uniffi-bindgen --version "^0.29" --locked && \
chmod -R a+w /usr/local/rustup /usr/local/cargo
# ── Android NDK (for zygisk) ─────────────────────────────────────────