vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-19 16:39:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

refactor: Fix stale references in qa-quality-prompt and test README (#2294)

Browse source 
- Fix qa-quality-prompt.md references to non-existent packages/shared/src/
  (only packages/cli/ exists; shared code lives in packages/cli/src/shared/)
- Add missing test file entries to __tests__/README.md:
  do-snapshot.test.ts and ui-utils.test.ts

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
A 2026-03-07 12:42:36 -08:00 • committed by GitHub
parent ce06492cb7
commit dadb2387e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.claude/skills/setup-agent-team/qa-quality-prompt.md
View file

@ -100,14 +100,14 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
**b) Stale references**: Scripts or code referencing files that no longer exist
- Shell scripts are under `sh/` (e.g., `sh/shared/`, `sh/e2e/`, `sh/test/`, `sh/{cloud}/`)
- TypeScript is under `packages/cli/src/` and `packages/shared/src/`
- TypeScript is under `packages/cli/src/`
- Grep for paths that reference old locations or deleted files and fix them
**c) Python usage**: Any `python3 -c` or `python -c` calls in shell scripts
- Replace with `bun eval` or `jq` as appropriate per CLAUDE.md rules
**d) Duplicate utilities**: Same helper function defined in multiple TypeScript cloud modules
- If identical, move to `packages/shared/src/` and have cloud modules import it
- If identical, move to `packages/cli/src/shared/` and have cloud modules import it
**e) Stale comments**: Comments referencing removed infrastructure, old test files, or deleted functions
- Remove or update these comments

2
packages/cli/src/__tests__/README.md
View file

@ -77,6 +77,8 @@ bun test src/__tests__/manifest.test.ts
- `check-entity.test.ts` / `check-entity-messages.test.ts` — Entity validation
- `agent-tarball.test.ts` — `tryTarballInstall`: GitHub Release tarball install, fallback, URL validation
- `gateway-resilience.test.ts` — `startGateway` systemd unit with auto-restart and cron heartbeat
- `do-snapshot.test.ts` — `findSpawnSnapshot`: DigitalOcean snapshot lookup, filtering, error handling
- `ui-utils.test.ts` — `validateServerName`, `validateRegionName`, `validateModelId`, `toKebabCase`, `sanitizeTermValue`, `jsonEscape`
### OAuth and auth
- `oauth-code-validation.test.ts` — `OAUTH_CODE_REGEX` format validation