From dadb2387e28e2c9abcf118bc64cd4e9a6b0d0b73 Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Sat, 7 Mar 2026 12:42:36 -0800 Subject: [PATCH] refactor: Fix stale references in qa-quality-prompt and test README (#2294) - Fix qa-quality-prompt.md references to non-existent packages/shared/src/ (only packages/cli/ exists; shared code lives in packages/cli/src/shared/) - Add missing test file entries to __tests__/README.md: do-snapshot.test.ts and ui-utils.test.ts Co-authored-by: spawn-qa-bot Co-authored-by: Claude Sonnet 4.6 --- .claude/skills/setup-agent-team/qa-quality-prompt.md | 4 ++-- packages/cli/src/__tests__/README.md | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.claude/skills/setup-agent-team/qa-quality-prompt.md b/.claude/skills/setup-agent-team/qa-quality-prompt.md index 24dfa92b..2c26ad70 100644 --- a/.claude/skills/setup-agent-team/qa-quality-prompt.md +++ b/.claude/skills/setup-agent-team/qa-quality-prompt.md @@ -100,14 +100,14 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N **b) Stale references**: Scripts or code referencing files that no longer exist - Shell scripts are under `sh/` (e.g., `sh/shared/`, `sh/e2e/`, `sh/test/`, `sh/{cloud}/`) - - TypeScript is under `packages/cli/src/` and `packages/shared/src/` + - TypeScript is under `packages/cli/src/` - Grep for paths that reference old locations or deleted files and fix them **c) Python usage**: Any `python3 -c` or `python -c` calls in shell scripts - Replace with `bun eval` or `jq` as appropriate per CLAUDE.md rules **d) Duplicate utilities**: Same helper function defined in multiple TypeScript cloud modules - - If identical, move to `packages/shared/src/` and have cloud modules import it + - If identical, move to `packages/cli/src/shared/` and have cloud modules import it **e) Stale comments**: Comments referencing removed infrastructure, old test files, or deleted functions - Remove or update these comments diff --git a/packages/cli/src/__tests__/README.md b/packages/cli/src/__tests__/README.md index 9c38fb1f..c2ad4e6c 100644 --- a/packages/cli/src/__tests__/README.md +++ b/packages/cli/src/__tests__/README.md @@ -77,6 +77,8 @@ bun test src/__tests__/manifest.test.ts - `check-entity.test.ts` / `check-entity-messages.test.ts` — Entity validation - `agent-tarball.test.ts` — `tryTarballInstall`: GitHub Release tarball install, fallback, URL validation - `gateway-resilience.test.ts` — `startGateway` systemd unit with auto-restart and cron heartbeat +- `do-snapshot.test.ts` — `findSpawnSnapshot`: DigitalOcean snapshot lookup, filtering, error handling +- `ui-utils.test.ts` — `validateServerName`, `validateRegionName`, `validateModelId`, `toKebabCase`, `sanitizeTermValue`, `jsonEscape` ### OAuth and auth - `oauth-code-validation.test.ts` — `OAUTH_CODE_REGEX` format validation