vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-13 15:40:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

refactor: Remove stale comment listing untested functions in run-path test (#2166)

Browse source 
The block comment in run-path-credential-display.test.ts listed five
functions it claimed to test, but the file only tests two:
  - prioritizeCloudsByCredentials
  - isRetryableExitCode

Functions buildCredentialStatusLines, formatAuthVarLine, validateRunSecurity,
and validateEntities were never imported or exercised in this file. Removed
the misleading entries so the comment accurately reflects test coverage.

-- qa/code-quality

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
This commit is contained in:
A 2026-03-03 21:24:44 -08:00 • committed by GitHub
parent 1097f055c3
commit 6334abe5a6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
packages/cli/src/__tests__/run-path-credential-display.test.ts
View file

@ -3,18 +3,11 @@ import { mockClackPrompts } from "./test-helpers";
import type { Manifest } from "../manifest";
/**
* Tests for critical-path functions in the `spawn <agent> <cloud>` run flow
* that had ZERO test coverage:
* Tests for critical-path functions in the `spawn <agent> <cloud>` run flow:
*
* - prioritizeCloudsByCredentials: sorts clouds by credential availability,
* builds hint overrides, counts clouds with credentials
* - buildCredentialStatusLines: builds credential status lines for dry-run preview
* - formatAuthVarLine: formats individual auth env var display lines
* - validateRunSecurity: validates agent/cloud/prompt before execution
* - validateEntities: validates agent + cloud exist in manifest before execution
*
* These functions are all in the hot path of cmdRun (the primary CLI flow).
* A bug in any of them breaks the user experience for every spawn invocation.
* - isRetryableExitCode: identifies exit codes that warrant a retry suggestion
*/
// ── Test manifest ───────────────────────────────────────────────────────