From 6334abe5a6779e08bc2d8a83df7eef792f0500c8 Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Tue, 3 Mar 2026 21:24:44 -0800 Subject: [PATCH] refactor: Remove stale comment listing untested functions in run-path test (#2166) The block comment in run-path-credential-display.test.ts listed five functions it claimed to test, but the file only tests two: - prioritizeCloudsByCredentials - isRetryableExitCode Functions buildCredentialStatusLines, formatAuthVarLine, validateRunSecurity, and validateEntities were never imported or exercised in this file. Removed the misleading entries so the comment accurately reflects test coverage. -- qa/code-quality Co-authored-by: spawn-qa-bot --- .../src/__tests__/run-path-credential-display.test.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/cli/src/__tests__/run-path-credential-display.test.ts b/packages/cli/src/__tests__/run-path-credential-display.test.ts index d15e786d..d2731bbb 100644 --- a/packages/cli/src/__tests__/run-path-credential-display.test.ts +++ b/packages/cli/src/__tests__/run-path-credential-display.test.ts @@ -3,18 +3,11 @@ import { mockClackPrompts } from "./test-helpers"; import type { Manifest } from "../manifest"; /** - * Tests for critical-path functions in the `spawn ` run flow - * that had ZERO test coverage: + * Tests for critical-path functions in the `spawn ` run flow: * * - prioritizeCloudsByCredentials: sorts clouds by credential availability, * builds hint overrides, counts clouds with credentials - * - buildCredentialStatusLines: builds credential status lines for dry-run preview - * - formatAuthVarLine: formats individual auth env var display lines - * - validateRunSecurity: validates agent/cloud/prompt before execution - * - validateEntities: validates agent + cloud exist in manifest before execution - * - * These functions are all in the hot path of cmdRun (the primary CLI flow). - * A bug in any of them breaks the user experience for every spawn invocation. + * - isRetryableExitCode: identifies exit codes that warrant a retry suggestion */ // ── Test manifest ───────────────────────────────────────────────────────