vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-22 03:14:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(e2e): correct stale test expectation for hermes timeout fallback (#3044)
Some checks are pending
CLI Release / Build and release CLI (push) Waiting to run
Details
Lint / ShellCheck (push) Waiting to run
Details
Lint / Biome Lint (push) Waiting to run
Details
Lint / macOS Compatibility (push) Waiting to run
Details

Browse source 
When AGENT_TIMEOUT_hermes is non-numeric, get_agent_timeout() skips the
env var and uses the built-in _AGENT_TIMEOUT_hermes=3600, NOT the global
AGENT_TIMEOUT=1800. The test expected ${AGENT_TIMEOUT} (1800) but the
function correctly returns 3600 (hermes built-in default). This test was
failing silently, masking the correct behavior.

Also filed OpenRouterTeam/spawn#3042 for cursor missing from e2e framework.

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: L <6723574+louisgv@users.noreply.github.com>
This commit is contained in:
A 2026-03-26 19:02:23 -07:00 • committed by GitHub
parent eeab2cac1f
commit 088e33b30e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sh/test/e2e-lib.sh
View file

@ -185,10 +185,10 @@ result=$(get_agent_timeout "hermes")
assert_eq "get_agent_timeout hermes (env override)" "500" "${result}"
unset AGENT_TIMEOUT_hermes
# Non-numeric env var ignored
# Non-numeric env var ignored — falls through to built-in hermes default (3600), not global
export AGENT_TIMEOUT_hermes="not-a-number"
result=$(get_agent_timeout "hermes")
assert_eq "get_agent_timeout hermes (non-numeric ignored)" "${AGENT_TIMEOUT}" "${result}"
assert_eq "get_agent_timeout hermes (non-numeric ignored)" "3600" "${result}"
unset AGENT_TIMEOUT_hermes
# --- Numeric validation (constants) ---