From 088e33b30e3f3051b2bfaa2d041c1e8d04225b6a Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Thu, 26 Mar 2026 19:02:23 -0700 Subject: [PATCH] fix(e2e): correct stale test expectation for hermes timeout fallback (#3044) When AGENT_TIMEOUT_hermes is non-numeric, get_agent_timeout() skips the env var and uses the built-in _AGENT_TIMEOUT_hermes=3600, NOT the global AGENT_TIMEOUT=1800. The test expected ${AGENT_TIMEOUT} (1800) but the function correctly returns 3600 (hermes built-in default). This test was failing silently, masking the correct behavior. Also filed OpenRouterTeam/spawn#3042 for cursor missing from e2e framework. Co-authored-by: spawn-qa-bot Co-authored-by: Claude Sonnet 4.6 Co-authored-by: L <6723574+louisgv@users.noreply.github.com> --- sh/test/e2e-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sh/test/e2e-lib.sh b/sh/test/e2e-lib.sh index e2279705..64ddd98d 100644 --- a/sh/test/e2e-lib.sh +++ b/sh/test/e2e-lib.sh @@ -185,10 +185,10 @@ result=$(get_agent_timeout "hermes") assert_eq "get_agent_timeout hermes (env override)" "500" "${result}" unset AGENT_TIMEOUT_hermes -# Non-numeric env var ignored +# Non-numeric env var ignored — falls through to built-in hermes default (3600), not global export AGENT_TIMEOUT_hermes="not-a-number" result=$(get_agent_timeout "hermes") -assert_eq "get_agent_timeout hermes (non-numeric ignored)" "${AGENT_TIMEOUT}" "${result}" +assert_eq "get_agent_timeout hermes (non-numeric ignored)" "3600" "${result}" unset AGENT_TIMEOUT_hermes # --- Numeric validation (constants) ---