ouroboros/.github/PULL_REQUEST_TEMPLATE.md
Anton Razzhigaev f627fa835d Contributor review: agentic checklist path, honest script-lane budget shape (#395)
- CONTRIBUTING makes the agentic checklist review the main path: the
  separate review agent covers all eight Intent/Scope checklist items from
  docs/CHECKLISTS.md under that checklist's own output contract, and the
  JSON receipt lands in the PR's review-evidence block (validated locally by
  scripts/validate_scope_receipt.py — a thin CLI over the runtime
  normalize_scope_items contract, no CI workflow changes).
- The project-native review command is honestly labeled maintainer /
  large-window tooling: the scope pack is required regardless of diff size
  and can exceed a default install's scope window (SCOPE_REVIEW_BLOCKED);
  the documented larger-window routes are an agent_session scope row or an
  API slot whose confirmed window fits the pack.
- Reading requirements proportioned: docs/CHECKLISTS.md stays
  read-in-full; the other four documents are mapped by headings with every
  relevant section read in full.
- PR template: scope-checklist coverage table + reviewer JSON block inside
  the single review-evidence section; governance wording matches.
- tests/test_contributor_flow.py pins the new copy and exercises the
  validator against the real contract (coverage, duplicates, broken JSON).
2026-08-31 15:51:01 +00:00

3.1 KiB

Summary

Scope

In scope:

Non-goals:

Verification

  • Focused tests for the changed behavior pass.
  • The default local test suite passes, or the reason it was not run is below.
  • Lint/static checks relevant to this change pass.

Commands and results:


Visual evidence

  • Not applicable; this PR has no visible UI change.
  • Before/after screenshots or other rendered-flow evidence are attached below.

Evidence:

Governance and documentation

  • I read CONTRIBUTING.md and docs/CHECKLISTS.md in full; for a substantive change I mapped BIBLE.md, docs/ARCHITECTURE.md, docs/DEVELOPMENT.md, and docs/DESIGN.md by their headings and read every section relevant to this change in full.
  • I updated tests and documentation where behavior or architecture changed.
  • I did not include secrets, local settings, runtime state, logs, caches, or generated build/review artifacts in the commit.
  • I did not bump VERSION or release-only version carriers; maintainers assign the collision-free release version during final integration.

Review evidence

  • Review status (PASS, NEEDS_CHANGES, INCOMPLETE, or NOT_RUN):
  • Authoring agent/context:
  • Separate review agent/context:
  • Reviewer model and effort (when exposed):
  • Reviewed base SHA:
  • Reviewed head SHA:
  • Findings and disposition:
  • Checks performed and coverage limitations:
  • Full review output or artifact link:
  • If not run, reason:

Scope checklist coverage (from the reviewer's JSON; one row per item, extra rows for additional FAIL findings on the same item):

Item Verdict Evidence
intent_alignment
forgotten_touchpoints
cross_surface_consistency
regression_surface
prompt_doc_sync
architecture_fit
cross_module_bugs
implicit_contracts
Reviewer checklist JSON (validate with scripts/validate_scope_receipt.py)

Final checklist

  • The PR base branch is ouroboros.
  • The branch is based on a current ouroboros revision.
  • The PR is one coherent change and is ready for maintainer integration.
  • The description explains any limitations, follow-up work, or compatibility impact.