mirror of
https://github.com/lfnovo/open-notebook.git
synced 2026-04-30 12:30:01 +00:00
Some checks failed
Development Build / extract-version (push) Has been cancelled
Tests / Backend Tests (push) Has been cancelled
Tests / Frontend Tests (push) Has been cancelled
Development Build / build-regular (push) Has been cancelled
Development Build / build-single (push) Has been cancelled
Development Build / summary (push) Has been cancelled
* feat(podcasts): integrate model registry for profiles and credential passthrough Replace loose provider/model string fields with record<model> references in podcast profiles, enabling credential passthrough to podcast-creator. Backend: - EpisodeProfile: outline_llm, transcript_llm (record<model>) replace outline_provider/outline_model strings. New language field (BCP 47). - SpeakerProfile: voice_model (record<model>) replaces tts_provider/ tts_model strings. Per-speaker voice_model override support. - Migration 14: schema changes making legacy fields optional, adding new record<model> fields. - Data migration (migration.py): auto-converts legacy profiles to model registry references on startup. Idempotent. - podcast_commands.py: resolves credentials for ALL profiles before calling podcast-creator. - New /api/languages endpoint (pycountry + babel) with BCP 47 locale codes (pt-BR, en-US, etc.). Frontend: - Episode/speaker profile forms use ModelSelector instead of manual provider/model dropdowns. - Language dropdown with BCP 47 codes in episode profile form. - Per-speaker TTS voice model override in speaker profile form. - "Templates" tab renamed to "Profiles". - Setup required badge on unconfigured profiles. - i18n updated across all 8 locales. Closes #486, closes #552 * fix(i18n): remove unused legacy podcast provider/model keys Remove 10 orphaned i18n keys across all 8 locales that were left behind after replacing manual provider/model dropdowns with ModelSelector. * fix: address review violations in podcast model registry - P1: Remove profiles with failed model resolution from dicts to prevent podcast-creator validation errors on unrelated profiles - P2: Use centralized QUERY_KEYS.languages instead of inline key - P3: Fix ISO 639-1 → BCP 47 in model field description and CLAUDE.md - P3: Update "templates" → "profiles" in locale string values (all 8) * chore: bump version to 1.8.0
7.4 KiB
7.4 KiB
Podcasts Module
Domain models for podcast generation featuring speaker and episode profile management with job tracking.
Purpose
Encapsulates podcast metadata and configuration: speaker profiles (voice/personality config), episode profiles (generation settings), and podcast episodes (with job status tracking via surreal-commands).
Architecture Overview
Two-tier profile system using the model registry for AI model references:
- SpeakerProfile:
voice_model(record reference) + 1-4 speaker configurations (name, voice_id, backstory, personality). Per-speakervoice_modeloverrides supported. - EpisodeProfile:
outline_llm/transcript_llm(record references) for LLM selection,languagefield (BCP 47 locale code), segment count, briefing template. - PodcastEpisode: Generated episode record linking profiles, content, and async job.
All inherit from ObjectModel (SurrealDB base class with table_name and save/load).
Component Catalog
models.py
_resolve_model_config(model_id) (module-level helper)
- Loads a Model record by ID, resolves its credential, returns
(provider, model_name, config_dict)tuple. - Used by
resolve_outline_config(),resolve_transcript_config(),resolve_tts_config(), and per-speaker TTS overrides inpodcast_commands.py. - Falls back to
provision_provider_keys()if no credential is linked.
SpeakerProfile
voice_model: Optionalrecord<model>reference for TTS (replaces legacytts_provider/tts_modelstrings).- Legacy fields
tts_provider/tts_modelkept as optional for migration compatibility. nullable_fieldsClassVar lists fields that may be null in the database.- Validates 1-4 speakers with required fields: name, voice_id, backstory, personality.
- Per-speaker
voice_modeloverride: individual speakers can reference a different TTS model. _prepare_save_data()convertsvoice_model(and per-speaker overrides) to RecordID before save.resolve_tts_config()resolvesvoice_modelvia_resolve_model_config(). Raises ValueError if not set.get_by_name()async query by profile name.
EpisodeProfile
outline_llm/transcript_llm: Optionalrecord<model>references (replace legacyoutline_provider/outline_model/transcript_provider/transcript_modelstrings).language: Optional BCP 47 locale code for podcast language (e.g.pt-BR,en-US).- Legacy fields kept as optional for migration compatibility.
nullable_fieldsClassVar lists fields that may be null in the database.num_segmentsvalidated between 3 and 20.- References
speaker_configby name. _prepare_save_data()convertsoutline_llm/transcript_llmto RecordID before save.resolve_outline_config()/resolve_transcript_config()resolve model references via_resolve_model_config(). Raise ValueError if not set.get_by_name()async query.
PodcastEpisode
- Stores episode_profile and speaker_profile as dicts (snapshots of config at generation time).
- Optional audio_file path, transcript/outline dicts.
- Job tracking: command field links to surreal-commands RecordID.
get_job_status()fetches async job status via surreal-commands library.get_job_detail()returns both status and error_message from the job (used for retry validation and UI error display)._prepare_save_data()ensures command field is always RecordID format for database.
migration.py
Data migration for podcast profiles: maps legacy provider/model strings to Model registry record IDs. Runs on API startup after SQL migrations (called from api/main.py lifespan).
_find_model_record(): Finds an existing Model record matching provider + name + type._find_or_create_model(): Finds existing Model record or auto-creates one linked to a provider credential.migrate_podcast_profiles(): Migrates all episode and speaker profiles. Idempotent -- skips profiles where new fields are already populated. Logs counts of migrated/skipped/failed profiles.
Common Patterns
- Model registry references: Profile fields reference
record<model>IDs instead of raw provider/model strings. Credentials are resolved at runtime via_resolve_model_config(). - Profile snapshots: episode_profile and speaker_profile stored as dicts on PodcastEpisode to freeze config at generation time.
- Field validation: Pydantic validators enforce constraints (segment count, speaker count, required fields).
- Async database access:
get_by_name()queries via repo_query. - Job tracking: command field delegates to surreal-commands; get_job_status() returns "unknown" on failure.
- Record ID handling:
_prepare_save_data()converts model ID strings to RecordID before save;ensure_record_id()handles both string and RecordID inputs. - nullable_fields ClassVar: Declares fields that may be null/absent in the database, allowing ObjectModel to handle them during deserialization.
Key Dependencies
pydantic: Field validators, ObjectModel inheritancesurrealdb: RecordID type for job and model referencesopen_notebook.database.repository: repo_query, ensure_record_idopen_notebook.domain.base: ObjectModel base classopen_notebook.ai.models: Model class (for_resolve_model_config)open_notebook.ai.key_provider: provision_provider_keys (fallback)open_notebook.domain.credential: Credential (for migration)surreal_commands(optional): get_command_status() for job status
Important Quirks & Gotchas
- Legacy fields preserved:
tts_provider/tts_modelon SpeakerProfile andoutline_provider/outline_model/transcript_provider/transcript_modelon EpisodeProfile are kept as optional nullable fields for backward compatibility with the data migration. The app ignores them at runtime. - Snapshot approach: Episode/speaker profiles stored as dicts (not references), so profile updates don't retroactively affect past episodes.
- Job status resilience: get_job_status() catches all exceptions and returns "unknown" (no error propagation).
- No automatic retries: Podcast generation commands use
retry={"max_attempts": 1}to prevent duplicate episode records on failure; retry is user-initiated viaPOST /podcasts/episodes/{id}/retry. - validate_speakers executes late: Validators run at instantiation; bulk inserts may not trigger full validation.
- RecordID coercion:
_prepare_save_data()converts model ID strings to RecordID; command field parsed during deserialization. - No cascade delete: Removing a profile doesn't cascade to episodes using it.
- Migration is idempotent:
migrate_podcast_profiles()skips profiles that already have new fields populated. Safe to run multiple times. - Migration auto-creates models: If a legacy provider/model string has no matching Model record but a credential exists for that provider, the migration auto-creates a Model record linked to the credential.
How to Extend
- Add new speaker field: Add to required_fields list in validate_speakers()
- Add episode config field: Validate in EpisodeProfile, update briefing generation code; add to nullable_fields if optional
- Add job metadata: Extend PodcastEpisode with new fields (e.g., progress tracking)
- Change job provider: Replace surreal-commands with alternative job queue library; update get_job_status()
- Add new model reference field: Add field, add to nullable_fields, add RecordID conversion in
_prepare_save_data(), add resolve method using_resolve_model_config()