* feat: replace provider config with credential-based system (#477) Introduce a new credential management system replacing the old ProviderConfig singleton and standalone Models page. Each credential stores encrypted API keys and provider-specific configuration with full CRUD support via a unified settings UI. Backend: - Add Credential domain model with encrypted API key storage - Add credentials API router (CRUD, discovery, registration, testing) - Add encryption utilities for secure key storage - Add key_provider for DB-first env-var fallback provisioning - Add connection tester and model discovery services - Integrate ModelManager with credential-based config - Add provider name normalization for Esperanto compatibility - Add database migrations 11-12 for credential schema Frontend: - Rewrite settings/api-keys page with credential management UI - Add model discovery dialog with search and custom model support - Add compact default model assignments (primary/advanced layout) - Add inline model testing and credential connection testing - Add env-var migration banner - Update navigation to unified settings page - Remove standalone models page and old settings components i18n: - Update all 7 locale files with credential and model management keys Closes #477 Co-Authored-By: JFMD <git@jfmd.us> Co-Authored-By: OraCatQAQ <570768706@qq.com> * fix: address PR #540 review comments - Fix docs referencing removed Models page - Fix error-handler returning raw messages instead of i18n keys - Fix auth.py misleading docstring and missing no-password guard - Fix connection_tester using wrong env var for openai_compatible - Add provision_provider_keys before model discovery/sync - Update CLAUDE.md to reflect credential-based system - Fix missing closing brace in api-keys page useEffect * fix: add logging to credential migration and surface errors in UI - Add comprehensive logging to migrate-from-env and migrate-from-provider-config endpoints (start, per-provider progress, success/failure with stack traces, final summary) - Fix frontend migration hooks ignoring errors array from response - Show error toast when migration fails instead of "nothing to migrate" - Invalidate status/envStatus queries after migration so banner updates * docs: update CLAUDE.md files for credential system Replace stale ProviderConfig and /api-keys/ references across 8 CLAUDE.md files to reflect the new Credential-based system from PR #540. * docs: update user documentation for credential-based system Replace env var API key instructions with Settings UI credential workflow across all user-facing documentation. The new flow is: set OPEN_NOTEBOOK_ENCRYPTION_KEY → start services → add credential in Settings UI → test → discover models → register. - Rewrite ai-providers.md, api-configuration.md, environment-reference.md - Update all quick-start guides and installation docs - Update ollama.md, openai-compatible.md, local-tts/stt networking sections - Update reverse-proxy.md, development-setup.md, security.md - Fix broken links to non-existent docs/deployment/ paths - Add credentials endpoints to api-reference.md - Move all API key env vars to deprecated/legacy sections * chore: bump version to 1.7.0-rc1 Release candidate for credential-based provider management system. * fix: initialize provider before try block in test_credential Prevents UnboundLocalError when Credential.get() throws (e.g., invalid credential_id) before provider is assigned. * fix: reorder down migration to drop index before table Removes duplicate REMOVE FIELD statement and reorders so the index is dropped before the table, preventing rollback failures. * refactor: simplify encryption key to always derive via SHA-256 Remove the dual code path in _ensure_fernet_key() that detected native Fernet keys. Since the credential system is new, always deriving via SHA-256 removes unnecessary complexity. Also removes the generate_key() function and Fernet.generate_key() references from docs. * fix: correct mock patch targets in embedding tests and URL validation Fix embedding tests patching wrong module path for model_manager (was targeting open_notebook.utils.embedding.model_manager but it's imported locally from open_notebook.ai.models). Also fix URL validation to allow unresolvable hostnames since they may be valid in the deployment environment (e.g., Azure endpoints, internal DNS). * feat: add global setup banner for encryption and migration status Show a persistent banner in AppShell when encryption key is missing (red) or env var API keys can be migrated (amber), so users see these prompts on every page instead of only on Settings > API Keys. Includes a docs link for the encryption banner and i18n support across all 7 locales. * docs: several improvements to docker-compose e env examples * Update README.md Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * docs: fix env var format in README and update model setup instructions Align the encryption key snippet in README Step 2 with the list format used in the compose file. Replace deprecated "Settings → Models" instructions with credential-based Discover Models flow. * fix: address credential system review issues - Fix SSRF bypass via IPv4-mapped IPv6 addresses (::ffff:169.254.x.x) - Fix TTS connection test missing config parameter - Add Azure-specific model discovery using api-key auth header - Add Vertex static model list for credential-based discovery - Fix PROVIDER_DISCOVERY_FUNCTIONS incorrect azure/vertex mapping - Extract business logic to api/credentials_service.py (service layer) - Move credential Pydantic schemas to api/models.py - Update tests to use new service imports and ValueError assertions * fix: sanitize error responses and migrate key_provider to Credential - Replace raw exception messages in all credential router 500 responses with generic error strings (internal details logged server-side only) - Refactor key_provider.py to use Credential.get_by_provider() instead of deprecated ProviderConfig.get_instance() - Remove unused functions (get_provider_configs, get_default_api_key, get_provider_config) that were dead code --------- Co-authored-by: JFMD <git@jfmd.us> Co-authored-by: OraCatQAQ <570768706@qq.com>
6.1 KiB
Domain Module
Core data models for notebooks, sources, notes, and settings with async SurrealDB persistence, auto-embedding, and relationship management.
Purpose
Two base classes support different persistence patterns: ObjectModel (mutable records with auto-increment IDs) and RecordModel (singleton configuration with fixed IDs).
Key Components
base.py
-
ObjectModel: Base for notebooks, sources, notes
save(): Create/update with auto-embedding for searchable contentdelete(): Remove by IDrelate(relationship, target_id): Create graph relationships (reference, artifact, refers_to)get(id): Polymorphic fetch; resolves subclass from ID prefixget_all(order_by): Fetch all records from table- Integrates with ModelManager for automatic embedding
-
RecordModel: Singleton configuration (ContentSettings, DefaultPrompts)
- Fixed record_id per subclass
update(): Upsert to database- Lazy DB loading via
_load_from_db()
notebook.py
-
Notebook: Research project container
get_sources(),get_notes(),get_chat_sessions(): Navigate relationshipsget_delete_preview(): Returns counts of notes, exclusive sources, and shared sources that would be affected by deletiondelete(delete_exclusive_sources): Cascade deletion - always deletes notes, optionally deletes exclusive sources, always unlinks all sources
-
Source: Content item (file/URL)
vectorize(): Submit async embedding job (returns command_id, fire-and-forget)get_status(),get_processing_progress(): Track job via surreal_commandsget_context(): Returns summary for LLM contextadd_insight(): Submit async insight creation viacreate_insight_command(fire-and-forget, returns command_id)
-
Note: Standalone or linked notes
save(): Submitsembed_notecommand after save (fire-and-forget)add_to_notebook(): Link to notebook
-
SourceInsight, SourceEmbedding: Derived content models
-
ChatSession: Conversation container with optional model_override
-
Asset: File/URL reference helper
-
Search functions:
text_search(): Full-text keyword searchvector_search(): Semantic search via embeddings (default minimum_score=0.2)
content_settings.py
- ContentSettings: Singleton for processing engines, embedding strategy, file deletion, YouTube languages
transformation.py
- Transformation: Reusable prompts for content transformation
- DefaultPrompts: Singleton with transformation instructions
credential.py
-
Credential: Individual credential records for API keys and provider configuration
- One record per credential: Each credential (e.g., "My OpenAI Key", "Work Anthropic") is a separate
Credentialrecord in SurrealDB - Fields: name, provider, modalities (list), api_key (SecretStr), base_url, endpoint, api_version, endpoint_llm/embedding/stt/tts, project, location, credentials_path
- SecretStr protection: API key field uses Pydantic's
SecretStr(values masked in logs/repr) - Encryption integration: Uses
encrypt_value()/decrypt_value()fromopen_notebook.utils.encryption- Keys encrypted with Fernet before database storage
- Requires
OPEN_NOTEBOOK_ENCRYPTION_KEYenvironment variable (warns if not set)
- Key methods:
to_esperanto_config(): Builds config dict for Esperanto's AIFactory methodsget_by_provider(provider): Class method to fetch all credentials for a providerget_linked_models(): Returns all Model records linked to this credential
- Custom serialization:
_prepare_save_data()extracts SecretStr values and encrypts before storage - Decryption on read:
get()andget_all()overridden to decrypt api_key after fetch
- One record per credential: Each credential (e.g., "My OpenAI Key", "Work Anthropic") is a separate
-
Note:
provider_config.pystill exists for legacy migration support (migrating old ProviderConfig records to Credential)
Important Patterns
- Async/await: All DB operations async; always use await
- Polymorphic get():
ObjectModel.get(id)determines subclass from ID prefix (table:id format) - Fire-and-forget embedding: Models submit embed_* commands after save via
submit_command()(non-blocking) - Nullable fields: Declare via
nullable_fieldsClassVar to allow None in database - Timestamps:
createdandupdatedauto-managed as ISO strings - Fire-and-forget jobs:
source.vectorize()returns command_id without waiting
Key Dependencies
surrealdb: RecordID type for relationshipspydantic: Validation and field_validator decoratorsopen_notebook.database.repository: CRUD and relationship functionsopen_notebook.ai.models: ModelManager for embeddingssurreal_commands: Async job submission (vectorization, insights)loguru: Logging
Quirks & Gotchas
- Polymorphic resolution:
ObjectModel.get()fails if subclass not imported (search subclasses list) - RecordModel singleton: new returns existing instance; call
clear_instance()in tests - Source.command field: Stored as RecordID; auto-parsed from strings via field_validator
- Text truncation:
Note.get_context(short)hardcodes 100-char limit - Auto-embedding behavior:
Note.save()→ auto-submitsembed_notecommandSource.save()→ does NOT auto-submit (must callvectorize()explicitly)Source.add_insight()→ submitscreate_insight_commandwhich handles DB insert +embed_insightcommand (all fire-and-forget)
- Relationship strings: Must match SurrealDB schema (reference, artifact, refers_to)
How to Add New Model
- Inherit from ObjectModel with table_name ClassVar
- Define Pydantic fields with validators
- Override
save()to submit embedding command if searchable (usesubmit_command("embed_*", id)) - Add custom methods for domain logic (get_X, add_to_Y)
- Implement
_prepare_save_data()if custom serialization needed
Usage
notebook = Notebook(name="Research", description="My project")
await notebook.save()
obj = await ObjectModel.get("notebook:123") # Polymorphic fetch
# Search
await text_search("quantum", results=5)
await vector_search("quantum computing", results=10, minimum_score=0.3)