mirror of https://github.com/odysseus-dev/odysseus.git synced 2026-08-29 18:31:47 +00:00

fix(auth): derive the session cookie Secure flag from the request scheme (#6048 )

* fix(auth): derive the session cookie Secure flag from the request scheme

SECURE_COOKIES only marked the login cookie Secure when it was explicitly
set to true, so an HTTPS login on an install that never set it handed out a
session cookie the browser is happy to send back in cleartext.

Unset now derives the flag from the request: the connection scheme, which
uvicorn's proxy-headers middleware rewrites for the proxies it trusts, or
X-Forwarded-Proto for a terminator that is not on a trusted address. That
is the same test core/middleware.py already applies before sending HSTS, so
the two stop disagreeing about whether a request arrived over TLS. An
explicit true still forces the flag on and an explicit false turns it off
for an install still answering on both HTTP and HTTPS. Strictly more Secure
flags than before and never fewer.

Empty counts as unset, because docker-compose pinned SECURE_COOKIES=false
for every container; the compose files now pass the variable through
unset, the way FASTEMBED_CACHE_PATH already does.

The helper and its decision order come from #3799, which was closed for
being too large to review and whose six replacement PRs dropped this fix.

Part of #3803.

* docs(setup): flag the leftover SECURE_COOKIES=false on upgrades

The old default was false, so an install set up before scheme derivation
can still carry an explicit SECURE_COOKIES=false in its own .env. That
value stays authoritative, so HTTPS logins keep getting a non-Secure
session cookie even after the tracked compose defaults are updated by a
pull. Say so where people look: the security notes and the variable's
own comment in .env.example.

* docs(setup): align TLS guidance with scheme-derived cookies

---------

Co-authored-by: Alexandre Teixeira <alexandremagteixeira@gmail.com>

2026-08-16 22:56:36 +01:00

2.7 KiB

Raw Permalink Blame History

Security Policy

Odysseus is a self-hosted AI workspace with privileged local capabilities. Please do not run it as a public, unauthenticated service.

Supported Versions

Security fixes are handled on the default branch until formal releases are cut.

Deployment Guidance

Keep AUTH_ENABLED=true for any network-accessible deployment.
Keep LOCALHOST_BYPASS=false outside local development.
Leave SECURE_COOKIES unset unless you need to override it: session cookies are marked Secure whenever the request arrives over HTTPS. Set SECURE_COOKIES=true to force it on (for a proxy Odysseus cannot see the scheme of), or SECURE_COOKIES=false to force it off while you still serve plain HTTP alongside HTTPS.
Use HTTPS when exposing the app beyond localhost.
Put the authenticated Odysseus web/API entrypoint behind a trusted reverse proxy or private access layer such as Cloudflare Access, Tailscale, or a VPN.
Keep ChromaDB, SearXNG, ntfy, Ollama, vLLM, llama.cpp, databases, and raw model/provider APIs internal-only.
Protect .env, data/, logs/, uploads, generated media, backups, auth/session files, database files, API keys, and model/provider tokens.
Disable open signup unless you intentionally want new accounts.
Keep demo/test users non-admin, and remove them entirely on serious deployments.
Give admin accounts strong passwords and enable 2FA where possible.
Leave high-risk agent tools restricted to admins: shell, Python, file read/write, email send/read, MCP, app API, task/skill/memory management, settings, tokens, and model serving.
Rotate API keys, webhook secrets, and Odysseus API tokens if they appear in logs, screenshots, demos, or shared chats.
Treat shell, model-serving, MCP, email, calendar, and vault features as privileged admin functionality.
Common internal-only ports are Odysseus 7000, SearXNG 8080, ntfy 8091, ChromaDB 8100, Ollama 11434, and local model/provider APIs such as 8000-8020.

Publishing A Fork

Before pushing a public fork, run:

git status --short
git check-ignore -v .env data/auth.json data/app.db logs/compound.log odysseus.db
git grep -n -I -E "(sk-[A-Za-z0-9_-]{20,}|xox[baprs]-|AIza[0-9A-Za-z_-]{20,}|Bearer [A-Za-z0-9._~+/-]{20,})" -- . ':!static/lib/**' ':!package-lock.json'

Only .env.example, docs, source, tests, and static assets should be committed. Never commit live .env values, data/ contents, local databases, uploaded files, generated media, logs, backups, auth/session files, API keys, model/provider tokens, password hashes, or personal documents.

Reporting

Please report vulnerabilities privately via GitHub security advisories if available, or by opening a minimal issue that does not disclose exploit details.