4786 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Boris Rorsvort	74aa4d6fa5	fix(ui): Search focus after clear (#4932) ... * wip * refactor implem * fixes	2026-02-21 14:39:38 -05:00
dependabot[bot]	dc4607c657	chore(deps): bump ajv from 6.12.6 to 6.14.0 in /ui (#5080) ... Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.12.6 to 6.14.0. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](https://github.com/ajv-validator/ajv/compare/v6.12.6...v6.14.0) --- updated-dependencies: - dependency-name: ajv dependency-version: 6.14.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-02-21 12:44:32 -05:00
Deluan	ddab0da207	docs: update commit message format in CONTRIBUTING.md ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-20 11:00:34 -05:00
Deluan Quintão	08a71320ea	fix(ui): make toggle switches visible in Gruvbox Dark theme (#5063) (#5064) ... The secondary color (#3c3836) matches the panel/table cell background, making checked MuiSwitch thumbs invisible. Add MuiSwitch override using Gruvbox cyan (#458588), consistent with existing interactive elements.	2026-02-18 15:38:20 -05:00
Raphael Catolino	44a5482493	fix(ui): activity Indicator switching constantly between online/offline (#5054) ... When using HTTP2, setting the writeTimeout too low causes the channel to close before the keepAlive event has a chance of beeing sent. Signed-off-by: rca <raphael.catolino@gmail.com> Co-authored-by: Deluan Quintão <deluan@navidrome.org>	2026-02-17 14:47:20 -05:00
Deluan	5fa8356b31	chore(deps): bump golangci-lint to v2.10.0 and suppress new gosec false positives ... Bump golangci-lint from v2.9.0 to v2.10.0, which includes a newer gosec with additional taint-analysis rules (G117, G703, G704, G705) and a stricter G101 check. Added inline //nolint:gosec comments to suppress 21 false positives across 19 files: struct fields flagged as secrets (G117), w.Write calls flagged as XSS (G705), HTTP client calls flagged as SSRF (G704), os.Stat/os.ReadFile/os.Remove flagged as path traversal (G703), and a sort mapping flagged as hardcoded credentials (G101). Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-17 09:28:42 -05:00
Deluan Quintão	cad9cdc53e	fix(scanner): preserve created_at when moving songs between libraries (#5055) ... * fix: preserve created_at when moving songs between libraries (#5050) When songs are moved between libraries, their creation date was being reset to the current time, causing them to incorrectly appear in "Recently Added". Three changes fix this: 1. Add hash:"ignore" to AlbumID in MediaFile struct so that Equals() works for cross-library moves (AlbumID includes library prefix, making hashes always differ between libraries) 2. Preserve album created_at in moveMatched() via CopyAttributes, matching the pattern already used in persistAlbum() for within-library album ID changes 3. Only set CreatedAt in Put() when it's zero (new files), and explicitly copy missing.CreatedAt to the target in moveMatched() as defense-in-depth for the INSERT code path * test: add regression tests for created_at preservation (#5050) Add tests covering the three aspects of the fix: - Scanner: moveMatched preserves missing track's created_at - Scanner: CopyAttributes called for album created_at on album change - Scanner: CopyAttributes not called when album ID stays the same - Persistence: Put sets CreatedAt to now for new files with zero value - Persistence: Put preserves non-zero CreatedAt on insert - Persistence: Put does not reset CreatedAt on update Also adds CopyAttributes to MockAlbumRepo for test support. * test: verify album created_at is updated in cross-library move test (#5050) Added end-to-end assertion in the cross-library move test to verify that the new album's CreatedAt field is actually set to the original value after CopyAttributes runs, not just that the method was called. This strengthens the test by confirming the mock correctly propagates the timestamp.	2026-02-17 08:37:05 -05:00
Deluan	b774133cd1	chore(deps): update go-sqlite3 to v1.14.34 and pocketbase/dbx to v1.12.0 ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-17 08:35:02 -05:00
Alanna	a20d56c137	fix(ui): prevent "Play Next" restarting play at top of queue (#5049) ... Set playIndex when rebuilding the queue in reducePlayNext so the music player library knows which track is currently playing. Without this, the library's loadNewAudioLists defaults playIndex to 0, causing playback to restart from the top of the queue on rapid "Play Next" actions. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-17 08:34:24 -05:00
Deluan	b64d8ad334	fix(server): return 404 instead of 500 for non-existent playlists ... The native API endpoints GET /playlist/{id}/tracks and GET /playlist/{id}/tracks/{id} were panicking with a nil pointer dereference (resulting in a 500) when the playlist did not exist. This happened because Tracks() returns nil for missing playlists, and the nil repository was passed directly to the rest handler. Extracted a shared playlistTracksHandler that checks for nil and returns 404 early. Added tests covering both the error and happy paths.	2026-02-15 22:39:27 -05:00
Paul Becker	f00af7f983	feat(ui): add Dracula theme (#5023) ... Signed-off-by: Paul Becker <p@becker.kiwi>	2026-02-12 16:42:34 -05:00
Deluan Quintão	875ffc2b78	fix(ui): update Danish, Portuguese (BR) translations from POEditor (#5039) ... Co-authored-by: navidrome-bot <navidrome-bot@navidrome.org>	2026-02-12 16:38:57 -05:00
ChekeredList71	885334c819	fix(ui): update Hungarian translation (#5041) ... * new strings added * "empty" solved --------- Co-authored-by: ChekeredList71 <asd@asd.com>	2026-02-12 16:36:05 -05:00
Deluan	ff86b9f2b9	ci: add GitHub Actions workflow for pushing translations to POEditor	2026-02-12 16:32:58 -05:00
Xabi	13d3d510f5	fix(ui): update Basque localisation (#5038) ... * Update Basque localisation Added missing strings and a couple of improvements. * Update resources/i18n/eu.json typo Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>	2026-02-12 15:52:37 -05:00
fxj368	656009e5f8	fix(i18n) update Chinese Simplified translation (#5025) ... * Update Chinese Simplified translation * fix some structural issue and an incorrect translation	2026-02-12 15:49:20 -05:00
Deluan	06b3a1f33e	fix(insights): update HasCustomPID logic to use default constants ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-12 14:33:25 -05:00
Kendall Garner	0f4e8376cb	feat(ui): add download config toml link, disable copy when clipboard not available (#5035)	2026-02-12 10:54:04 -05:00
Deluan	199cde4109	fix: upgrade go-taglib to latest version ... Updated the go-taglib dependency to pick up the latest bug fixes from the forked repository. This resolves an issue reported in #5037.	2026-02-12 10:12:04 -05:00
Deluan	897de02a84	docs: documents how subsonic e2e tests are structured	2026-02-11 22:49:41 -05:00
Deluan	7ee56fe3bf	chore: update golangci-lint version to v2.9.0 in Makefile ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-11 08:31:51 -05:00
Kendall Garner	34c6f12aee	feat(server): add explicit status support in smart playlists (#5031) ... * feat(smart playlist): add explicit status support * retrigger checks * rename field (remove snake_case) Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org> Co-authored-by: Deluan <deluan@navidrome.org>	2026-02-10 18:22:34 -05:00
Denisa Rissa	eb9ebc3fba	fix(ui): add missing keys in Danish translation (#5011) ... update Danish translation with 59 missing keys for the `resources.plugin` section as well as `message.startingInstantMix`, `resources.song.actions.instantMix`, `resources.song.fields.composer`, and `resources.plugin.name`.	2026-02-10 14:05:14 -05:00
Deluan	e05a7e230f	fix: prevent data race on conf.Server during cleanup in e2e tests ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-10 11:25:17 -05:00
Rob Emery	62f9c3a458	fix: linux service should restart when upgrading (#5001) ... * When upgrading packages this should restart the service * We need to specify configfile otherwise this command doesn't work	2026-02-09 17:11:45 -05:00
Deluan	fd09ca103f	fix(scanner): resolve data race on conf.Server access in getScanner ... Captured DevExternalScanner config value in the controller struct at construction time instead of reading the global conf.Server pointer in getScanner(). The background goroutine spawned by ScanFolders() was reading conf.Server.DevExternalScanner concurrently with test cleanup reassigning the conf.Server pointer, causing a data race detected by the race detector in the E2E test suite.	2026-02-09 16:42:05 -05:00
Deluan Quintão	ed79a8897b	fix(scanner): pass filename hint to gotaglib's OpenStream for format detection (#5012) ... * fix: split reflex -R flags to preserve directory exclusion optimization Combining the _test.go exclusion pattern (which uses $) into the same -R regex as the directory prefixes (^ui, ^data, ^db/migrations) disabled reflex's ExcludePrefix optimization. Reflex disables prefix-based directory skipping when the regex AST contains $, \z, or \b operators, causing it to traverse into ui/node_modules and hit "too many open files". Splitting into two separate -R flags fixes this: the directory prefix regex remains $-free so ExcludePrefix works, while the _test.go pattern gets its own flag where the $ anchor doesn't affect directory skipping. * fix(gotaglib): pass filename hint to OpenStream for format detection OpenStream relies on content-sniffing when no filename is provided, which fails for some files (e.g. OPUS). Pass the filename via the new WithFilename option so TagLib can use the file extension as a hint. Also adds an OPUS test fixture and test entry. Relates to https://github.com/navidrome/navidrome/issues/4604#issuecomment-3868569113, #4998, #5010	2026-02-09 16:16:28 -05:00
Deluan	302d99aa8b	chore(deps): update dependencies in go.mod and go.sum ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-09 16:05:37 -05:00
Deluan	bee0305831	fix: split reflex -R flags to preserve directory exclusion optimization ... Combining the _test.go exclusion pattern (which uses $) into the same -R regex as the directory prefixes (^ui, ^data, ^db/migrations) disabled reflex's ExcludePrefix optimization. Reflex disables prefix-based directory skipping when the regex AST contains $, \z, or \b operators, causing it to traverse into ui/node_modules and hit "too many open files". Splitting into two separate -R flags fixes this: the directory prefix regex remains $-free so ExcludePrefix works, while the _test.go pattern gets its own flag where the $ anchor doesn't affect directory skipping.	2026-02-09 10:47:30 -05:00
Deluan	c280dd67a4	refactor: run Go modernize ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-09 08:44:44 -05:00
Deluan Quintão	8319905d2c	test(subsonic): add comprehensive e2e test suite for Subsonic API (#5003) ... * test(e2e): add comprehensive tests for Subsonic API endpoints Signed-off-by: Deluan <deluan@navidrome.org> * fix(e2e): improve database handling and snapshot restoration in tests Signed-off-by: Deluan <deluan@navidrome.org> * test(e2e): add tests for album sharing and user isolation scenarios Signed-off-by: Deluan <deluan@navidrome.org> * test(e2e): add tests for multi-library support and user access control Signed-off-by: Deluan <deluan@navidrome.org> * test(e2e): tests are fast, no need to skip on -short Signed-off-by: Deluan <deluan@navidrome.org> * address gemini comments Signed-off-by: Deluan <deluan@navidrome.org> * fix(tests): prevent MockDataStore from caching repos with stale context When RealDS is set, MockDataStore previously cached repository instances on first access, binding them to the initial caller's context. This meant repos created with an admin context would skip library filtering for all subsequent non-admin calls, silently masking access control bugs. Changed MockDataStore to delegate to RealDS on every call without caching, so each caller gets a fresh repo with the correct context. Removed the pre-warm calls in e2e setupTestDB that were working around the old caching behavior. * test(e2e): route subsonic tests through full HTTP middleware stack Replace direct router method calls with full HTTP round-trips via router.ServeHTTP(w, r) across all 15 e2e test files. Tests now exercise the complete chi middleware chain including postFormToQueryParams, checkRequiredParameters, authenticate, UpdateLastAccessMiddleware, getPlayer, and sendResponse/sendError serialization. New helpers (doReq, doReqWithUser, doRawReq, buildReq, parseJSONResponse) use plaintext password auth and JSON response format. Old helpers that injected context directly (newReq, newReqWithUser, newRawReq) are removed. Sharing tests now set conf.Server.EnableSharing before router creation to ensure sharing routes are registered. --------- Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-09 08:24:37 -05:00
Deluan	c80ef8ae41	chore: ignore _test.go files in reflex conf ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-08 20:06:19 -05:00
Deluan	0a4722802a	fix(subsonic): validate JSONP callback parameter ... Added validation to ensure the JSONP callback parameter is a valid JavaScript identifier before reflecting it into the response. Invalid callbacks now return a JSON error response instead. This prevents malicious input from being injected into the response body via the callback parameter.	2026-02-08 10:33:46 -05:00
Maximilian	a704e86ac1	refactor: run Go modernize (#5002)	2026-02-08 09:57:30 -05:00
Deluan	408aa78ed5	fix(scanner): log warning when metadata extraction fails ... Added a warning log when the gotaglib extractor fails to read metadata from a file. Previously, extraction errors were silently skipped, making it difficult to diagnose issues with unreadable files during scanning. Ref: https://github.com/navidrome/navidrome/issues/4604#issuecomment-3865690165 Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-07 21:39:07 -05:00
Deluan	29f98b889b	chore(deps): update dependencies in go.mod and go.sum to latest versions ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-07 13:23:58 -05:00
Kendall Garner	1e37e680d7	feat(agents): Add artist url and top and similar songs to ListenBrainz agent (#4934) ... * feat(agents): Add artist url and top songs to ListenBrainz agent * add newline at end of file * respond to some feedback * add more tests, include more metadata in top songs * add duration to album info * add similar artists from labs * add similar artists and track radio * fix(client): replace sort with slices.SortFunc for deterministic ordering of recordings with same score Signed-off-by: Deluan <deluan@navidrome.org> * fix: typos Signed-off-by: Deluan <deluan@navidrome.org> * refactor: use struct literal initialization consistently Signed-off-by: Deluan <deluan@navidrome.org> * feat: configurable artist and track algorithms Signed-off-by: Deluan <deluan@navidrome.org> * test configuration changes --------- Signed-off-by: Deluan <deluan@navidrome.org> Co-authored-by: Deluan Quintão <deluan@navidrome.org> Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-07 13:20:42 -05:00
Kendall Garner	6fb4cd277e	feat(subsonic): add OS readonly and validUntil properties in playlists (#4993) ... * feat(subsonic): add OS readonly and validUntil properties * remove duplicated test * test: fix and enable disabled child smart playlist tests Fixed the XContext("child smart playlists") tests that were disabled with a TODO comment. The tests had several issues: nested playlists were missing Public: true (required by InPlaylist criteria), the criteria matched no test fixtures, the "not expired" test set EvaluatedAt on the parent too (preventing it from refreshing at all), and the "expired" test dereferenced a nil EvaluatedAt. Added proper cleanup with DeferCleanup and config restoration via configtest. * fix(subsonic): always include readonly field in JSON playlist responses Removed omitempty from the JSON tag of the Readonly field in OpenSubsonicPlaylist so that readonly: false is always serialized in JSON responses, per the OpenSubsonic spec requirement that supported fields must be returned with default values. Added a test case with an empty OpenSubsonicPlaylist to verify the behavior. --------- Co-authored-by: Deluan Quintão <deluan@navidrome.org>	2026-02-06 19:35:54 -05:00
Deluan	e11206f0ee	fix(lastfm): clean up Last.fm content by removing "Read more" links from descriptions and bios ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-06 16:52:34 -05:00
Deluan Quintão	b4e03673ba	fix(scanner): preserve parentheses in lyrics when processing alias tags (#4985) ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-06 16:21:35 -05:00
Deluan	01c839d9be	fix: add music.old to .dockerignore and .gitignore	2026-02-06 07:40:05 -05:00
Kendall Garner	2731e25fd2	fix(ui): use div for fragment, check lastfm url for artist page (#4980) ... * fix(ui): use div for fragment, check lastfm url for artist page * use span instead of div for better compat * fix: implement isLastFmURL utility and add tests for URL validation --------- Co-authored-by: Deluan <deluan@navidrome.org>	2026-02-04 17:34:26 -05:00
Boris Rorsvort	4f3845bbe3	fix(ui): Nautiline theme font path (#4983) ... * fix: Nautiline theme font path * refactor font path	2026-02-04 17:24:30 -05:00
Deluan Quintão	e8863ed147	feat(plugins): add SubsonicAPI CallRaw, with support for raw=true binary response for host functions (#4982) ... * feat: implement raw binary framing for host function responses Signed-off-by: Deluan <deluan@navidrome.org> * feat: add CallRaw method for Subsonic API to handle binary responses Signed-off-by: Deluan <deluan@navidrome.org> * test: add tests for raw=true methods and binary framing generation Signed-off-by: Deluan <deluan@navidrome.org> * fix: improve error message for malformed raw responses to indicate incomplete header Signed-off-by: Deluan <deluan@navidrome.org> * fix: add wasm_import_module attribute for raw methods and improve content-type handling Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-04 15:48:08 -05:00
dependabot[bot]	19ea338bed	chore(deps): bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 in /ui (#4974) ... Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-02-04 10:12:00 -05:00
dependabot[bot]	338853468f	chore(deps): bump bytes in /plugins/pdk/rust/nd-pdk-host (#4973) ... Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](https://github.com/tokio-rs/bytes/compare/v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2026-02-04 10:11:37 -05:00
Deluan	4e720ee931	fix: handle WASM runtime panics in gotaglib openFile function. ... see #4977 Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-03 22:56:47 -05:00
dependabot[bot]	0c8f2a559c	chore(deps): bump lodash from 4.17.21 to 4.17.23 in /ui (#4922) ... Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deluan Quintão <deluan@navidrome.org>	2026-02-03 13:12:53 -05:00
Deluan Quintão	a1036e75a9	fix(ui): update Catalan, German, Spanish, French, Indonesian, Polish translations from POEditor (#4960) ... Co-authored-by: navidrome-bot <navidrome-bot@navidrome.org>	2026-02-03 12:50:16 -05:00
Deluan	2829cec0ce	fix(subsonic): add SubMusic to default MinimalClients list ... Signed-off-by: Deluan <deluan@navidrome.org>	2026-02-03 12:46:39 -05:00