518e0e2c70
* fix(tui): show quit feedback during the cold-start fill and exit on the second q (#1143) Follow-up to #1142. With the input fix in place, q pressed during the post-paint background index landed instantly but the exit path drained the fill first - a deterministic ~16.5s silent wait on a 21k-file corpus. The first q while the fill is active now arms a confirmation and renders 'Finishing background index so the next launch starts warm - press q or Ctrl+C again to quit now' in the footer area, styled to match the StatusBar (DIM border, ORANGE accent on the action key). The second q takes the abrupt path, which #1109 already proved kill-safe (nothing marked seen without being parsed, resume converges). Ctrl+C is unchanged: it always exits through the abrupt path, whether or not the confirmation is armed. q with no fill active exits immediately as before, with no status-line flicker. The confirmation auto-clears the moment the fill lands so a stale flag can never trap a later q. The fill's indexing signal already flows to the dashboard (the #1109 banner reuses it), so no new global state was introduced. Pinning tests added to tests/dashboard-exit.test.ts. BREAKING NOTE FOR 0.9.22: ships in 0.9.22, not Unreleased. * test: flush the unmount frame before the no-flicker assertion
1.8 KiB
Task: fix issue #1143 (read: gh issue view 1143). Branch: create fix/1143-quit-feedback off main.
Behavior to build
Pressing q during the post-paint background index currently drains the fill silently (~16.5s deterministic on a 21k-file corpus) before exiting. Wanted, exactly:
- First q during an active fill: begin the graceful drain AND immediately render a status line in the dashboard footer area: "Finishing background index so the next launch starts warm - press q or Ctrl+C again to quit now" (no em-dashes; match existing footer styling).
- A second q (or Ctrl+C at any time) during the drain: immediate exit through the same abrupt path Ctrl+C already uses - #1109 made abrupt exit kill-safe (nothing marked seen without being parsed; resume converges), so this is safe by design. Do not weaken those invariants.
- q when NO fill is active: exits immediately as today (no status line flicker).
- Ctrl+C semantics unchanged (immediate, always).
Where
src/dashboard.tsx useInput (the q/Ctrl+C handler shipped in #1142) + wherever fill-active state is visible to the dashboard (the #1109 fill exposes indexing progress for the banner - reuse that signal; do not invent new global state if a fill-status already flows to the UI).
Tests (repo conventions - see tests/dashboard-exit.test.ts from #1142)
- first q during active fill: no exit, status line rendered;
- second q: exits;
- Ctrl+C during drain: exits;
- q with no active fill: exits immediately, no status line.
Gates
npx vitest run full suite green (~3708); npx tsc --noEmit clean. CHANGELOG: add to the section "## 0.9.22 - 2026-08-25" (NOT Unreleased - this ships in 0.9.22) under Fixed (TUI), house style, cite #1143. Commit on branch, push, STOP (no PR). Do not commit BRIEF.md. Only src/dashboard.tsx-adjacent + tests + CHANGELOG; do not touch the save/fill machinery itself.