vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-07-10 00:14:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Guard against duplicate WorkloadsFilter on platform overview pages

Browse source 
Add a platformOverviewLayout guardrail that asserts the Proxmox and
vSphere overview surfaces each render exactly one <WorkloadsFilter>
and pass suppressFilterToolbar to the embedded <WorkloadsSurface>.
This is the regression that shipped in 6.0.0-rc.6: both pages owned a
shared page-level filter and the embedded surface still rendered its
own, producing two stacked toolbars wired to the same state.
This commit is contained in:
rcourtman 2026-05-28 09:42:09 +01:00
parent d66d774c0e
commit be2f6324f0
1 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

20
frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
View file

@ -314,6 +314,26 @@ describe('platform overview layout guardrails', () => {
}
});
it('keeps platform overview pages from rendering a duplicate WorkloadsFilter', () => {
// Proxmox and vSphere overview pages render their own page-level
// WorkloadsFilter above the embedded WorkloadsSurface so a single
// toolbar drives both the page's top table and the workloads table.
// If the embedded surface also renders its own filter the page ends
// up with two stacked toolbars wired to the same state (RC6 bug).
const surfacesWithSharedToolbar: Array<[string, string]> = [
['ProxmoxPageSurface', proxmoxPageSurfaceSource],
['VmwarePageSurface', vmwarePageSurfaceSource],
];
for (const [name, source] of surfacesWithSharedToolbar) {
const filterCount = (source.match(/<WorkloadsFilter\b/g) ?? []).length;
expect(filterCount, `${name} should render exactly one <WorkloadsFilter>`).toBe(1);
expect(
/<WorkloadsSurface\b[^>]*?suppressFilterToolbar/s.test(source),
`${name} should pass suppressFilterToolbar to <WorkloadsSurface>`,
).toBe(true);
}
});
it('keeps mobile host tables focused on useful operational columns', () => {
// Assertions use the canonical kind-based helpers
// (getPlatformTableHeadClassForKind('<kind>')) so the platform overview