From be2f6324f0352bd8b25d2df5bbda4d587dd6166b Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Thu, 28 May 2026 09:42:09 +0100
Subject: [PATCH] Guard against duplicate WorkloadsFilter on platform overview
 pages

Add a platformOverviewLayout guardrail that asserts the Proxmox and
vSphere overview surfaces each render exactly one <WorkloadsFilter>
and pass suppressFilterToolbar to the embedded <WorkloadsSurface>.
This is the regression that shipped in 6.0.0-rc.6: both pages owned a
shared page-level filter and the embedded surface still rendered its
own, producing two stacked toolbars wired to the same state.
---
 .../platformOverviewLayout.guardrails.test.ts | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
index f7d60de18..7dfaae110 100644
--- a/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
+++ b/frontend-modern/src/features/platformPage/__tests__/platformOverviewLayout.guardrails.test.ts
@@ -314,6 +314,26 @@ describe('platform overview layout guardrails', () => {
     }
   });
 
+  it('keeps platform overview pages from rendering a duplicate WorkloadsFilter', () => {
+    // Proxmox and vSphere overview pages render their own page-level
+    // WorkloadsFilter above the embedded WorkloadsSurface so a single
+    // toolbar drives both the page's top table and the workloads table.
+    // If the embedded surface also renders its own filter the page ends
+    // up with two stacked toolbars wired to the same state (RC6 bug).
+    const surfacesWithSharedToolbar: Array<[string, string]> = [
+      ['ProxmoxPageSurface', proxmoxPageSurfaceSource],
+      ['VmwarePageSurface', vmwarePageSurfaceSource],
+    ];
+    for (const [name, source] of surfacesWithSharedToolbar) {
+      const filterCount = (source.match(/<WorkloadsFilter\b/g) ?? []).length;
+      expect(filterCount, `${name} should render exactly one <WorkloadsFilter>`).toBe(1);
+      expect(
+        /<WorkloadsSurface\b[^>]*?suppressFilterToolbar/s.test(source),
+        `${name} should pass suppressFilterToolbar to <WorkloadsSurface>`,
+      ).toBe(true);
+    }
+  });
+
   it('keeps mobile host tables focused on useful operational columns', () => {
     // Assertions use the canonical kind-based helpers
     // (getPlatformTableHeadClassForKind('<kind>')) so the platform overview