Removed redundant transactions (59f59e3ccd)

This commit is contained in:
Antoine Gersant 2020-01-18 13:23:22 -08:00
parent a4991a620e
commit 95f6c62531

View file

@ -183,12 +183,9 @@ impl IndexBuilder {
#[cfg_attr(feature = "profile-index", flame)] #[cfg_attr(feature = "profile-index", flame)]
fn flush_songs(&mut self) -> Result<()> { fn flush_songs(&mut self) -> Result<()> {
let connection = self.db.connect()?; let connection = self.db.connect()?;
connection.transaction::<_, anyhow::Error, _>(|| { diesel::insert_into(songs::table)
diesel::insert_into(songs::table) .values(&self.new_songs)
.values(&self.new_songs) .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822
.execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822
Ok(())
})?;
self.new_songs.clear(); self.new_songs.clear();
Ok(()) Ok(())
} }
@ -196,12 +193,9 @@ impl IndexBuilder {
#[cfg_attr(feature = "profile-index", flame)] #[cfg_attr(feature = "profile-index", flame)]
fn flush_directories(&mut self) -> Result<()> { fn flush_directories(&mut self) -> Result<()> {
let connection = self.db.connect()?; let connection = self.db.connect()?;
connection.transaction::<_, anyhow::Error, _>(|| { diesel::insert_into(directories::table)
diesel::insert_into(directories::table) .values(&self.new_directories)
.values(&self.new_directories) .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822
.execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822
Ok(())
})?;
self.new_directories.clear(); self.new_directories.clear();
Ok(()) Ok(())
} }