From 95f6c62531f0e13c4efd717eac39f62df87b7c4c Mon Sep 17 00:00:00 2001 From: Antoine Gersant Date: Sat, 18 Jan 2020 13:23:22 -0800 Subject: [PATCH] Removed redundant transactions (https://github.com/diesel-rs/diesel/commit/59f59e3ccd96531f568e75b2ffad10b4b21e05e9) --- src/index.rs | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/index.rs b/src/index.rs index 70b80a6..feac2af 100644 --- a/src/index.rs +++ b/src/index.rs @@ -183,12 +183,9 @@ impl IndexBuilder { #[cfg_attr(feature = "profile-index", flame)] fn flush_songs(&mut self) -> Result<()> { let connection = self.db.connect()?; - connection.transaction::<_, anyhow::Error, _>(|| { - diesel::insert_into(songs::table) - .values(&self.new_songs) - .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822 - Ok(()) - })?; + diesel::insert_into(songs::table) + .values(&self.new_songs) + .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822 self.new_songs.clear(); Ok(()) } @@ -196,12 +193,9 @@ impl IndexBuilder { #[cfg_attr(feature = "profile-index", flame)] fn flush_directories(&mut self) -> Result<()> { let connection = self.db.connect()?; - connection.transaction::<_, anyhow::Error, _>(|| { - diesel::insert_into(directories::table) - .values(&self.new_directories) - .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822 - Ok(()) - })?; + diesel::insert_into(directories::table) + .values(&self.new_directories) + .execute(&*connection)?; // TODO https://github.com/diesel-rs/diesel/issues/1822 self.new_directories.clear(); Ok(()) }