mirror of
https://github.com/zed-industries/zed.git
synced 2026-06-01 14:20:35 +00:00
1f4c9b9427
As suggested in https://github.com/zed-industries/zed/pull/34418, this proposes various changes to language configs to make block comments and doc-block-style comments more similar. In doing so, it introduces some breaking changes into the extension schema. This change is needed to support the changes I'm working on in #34418, to be able to support `rewrap` in block comments like `/* really long comment ... */`. As is, we can do this in C-style doc-block comments (eg `/** ... */`) because of the config in `documentation`, but we can't do this in regular block comments because we lack the info about what the line prefix and indentation should be. And while I was here, I did various other clean-ups, many of which feel nice but are optional. I would love special attention on the changes to the schema, version and related changes; I'm totally unfamiliar with that part of Zed. **Summary of changes** - break: changes type of `block_comment` to same type as `documentation_comment` (**this is the important change**) - break: rename `documentation` to `documentation_comment` (optional, but improves consistency w/ `line_comments` and `block_comment`) - break/refactor?: removes some whitespace in the declaration of `block_comment` delimiters (optional, may break things, need input; some langs had no spaces, others did) - refactor: change `tab_size` from `NonZeroU32` to just a `u32` (some block comments don't seem to need/want indent past the initial delimiter, so we need this be 0 sometimes) - refactor: moves the `documentation_comment` declarations to appear next to `block_comment`, rearranges the order of the fields in the TOML for `documentation_comment`, rename backing `struct` (all optional) **Future scope** I believe that this will also allow us to extend regular block comments on newline – as we do doc-block comments – but I haven't looked into this yet. (eg, in JS try pressing enter in both of these: `/* */` and `/** */`; the latter should extend w/ a `*` prefixed line, while the former does not.) Release Notes: - BREAKING CHANGE: update extension schema version from 1 to 2, change format of `block_comment` and rename `documentation_comment` /cc @smitbarmase |
||
|---|---|---|
| .. | ||
| display_map | ||
| git | ||
| scroll | ||
| test | ||
| actions.rs | ||
| blink_manager.rs | ||
| clangd_ext.rs | ||
| code_completion_tests.rs | ||
| code_context_menus.rs | ||
| display_map.rs | ||
| editor.rs | ||
| editor_settings.rs | ||
| editor_settings_controls.rs | ||
| editor_tests.rs | ||
| element.rs | ||
| git.rs | ||
| highlight_matching_bracket.rs | ||
| hover_links.rs | ||
| hover_popover.rs | ||
| indent_guides.rs | ||
| inlay_hint_cache.rs | ||
| inline_completion_tests.rs | ||
| items.rs | ||
| jsx_tag_auto_close.rs | ||
| linked_editing_ranges.rs | ||
| lsp_colors.rs | ||
| lsp_ext.rs | ||
| mouse_context_menu.rs | ||
| movement.rs | ||
| persistence.rs | ||
| proposed_changes_editor.rs | ||
| rust_analyzer_ext.rs | ||
| scroll.rs | ||
| selections_collection.rs | ||
| signature_help.rs | ||
| tasks.rs | ||
| test.rs | ||