vrr/zed
2
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-08-22 23:45:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13
zed/crates/cli
History
Jonas Lundholm Bertelsen debf6b218c
cli: Fix Flatpak launcher argument ordering (#61577) 
Closes https://github.com/zed-industries/zed/issues/62801

# Objective

Fix issue https://github.com/flathub/dev.zed.Zed/issues/395 (reported
against the flathub package, but as described in it, it was introduced
by https://github.com/zed-industries/zed/pull/57440 ).

The symptom was that when running `flatpak run dev.zed.Zed <project
path>` (or some alias), then you'd get two "files" opened `--zed` and
`zed-editor`, with `zed-editor` also being added to the Zed project list
in the open window, which was quite annoying.

## Solution

- The flatpak CLI launcher, which self-launches with potential extra
arguments, now puts those arguments first rather than last.

## Testing

- A simple unit test targets the helper function that adds the arguments
- It also verifies that the parsed args come out as expected

## Self-Review Checklist:

- [ x ] I've reviewed my own diff for quality, security, and reliability
- [ x ] Unsafe blocks (if any) have justifying comments
- [ x ] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [ x ] Tests cover the new/changed behavior
- [ x ] Performance impact has been considered and is acceptable

Note: I believe that other bullets than self-review and tests are not
relevant, as there is no unsafe, no expected performance impact, and no
UI changes.

---

Release Notes:

- Fixed an issue where Flatpak CLI launches would open
unrelated/nonexistent files due to a bug in argument construction

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
2026-08-20 16:37:31 +00:00
..
src cli: Fix Flatpak launcher argument ordering (#61577) 2026-08-20 16:37:31 +00:00
build.rs Fix Windows icon resource for bin zed.exe (#54738) 2026-05-01 22:33:54 +00:00
Cargo.toml Add shell completions for CLI (#57440) 2026-06-22 14:57:34 +00:00
LICENSE-GPL
README.md remote: Support line and column numbers for remote paths (#40410) 2025-10-17 10:50:22 +00:00

README.md

Cli

Testing

You can test your changes to the cli crate by first building the main zed binary:

cargo build -p zed

And then building and running the cli crate with the following parameters:

 cargo run -p cli -- --zed ./target/debug/zed.exe