mirror of
https://github.com/zed-industries/zed.git
synced 2026-05-26 15:44:20 +00:00
ef5b8c6fed
We've been considering removing workspace-hack for a couple reasons: - Lukas ran into a situation where its build script seemed to be causing spurious rebuilds. This seems more likely to be a cargo bug than an issue with workspace-hack itself (given that it has an empty build script), but we don't necessarily want to take the time to hunt that down right now. - Marshall mentioned hakari interacts poorly with automated crate updates (in our case provided by rennovate) because you'd need to have `cargo hakari generate && cargo hakari manage-deps` after their changes and we prefer to not have actions that make commits. Currently removing workspace-hack causes our workspace to grow from ~1700 to ~2000 crates being built (depending on platform), which is mainly a problem when you're building the whole workspace or running tests across the the normal and remote binaries (which is where feature-unification nets us the most sharing). It doesn't impact incremental times noticeably when you're just iterating on `-p zed`, and we'll hopefully get these savings back in the future when rust-lang/cargo#14774 (which re-implements the functionality of hakari) is finished. Release Notes: - N/A |
||
|---|---|---|
| .. | ||
| bump_collab_staging.yml | ||
| bump_patch_version.yml | ||
| ci.yml | ||
| community_champion_auto_labeler.yml | ||
| community_close_stale_issues.yml | ||
| community_release_actions.yml | ||
| community_update_all_top_ranking_issues.yml | ||
| community_update_weekly_top_ranking_issues.yml | ||
| congrats.yml | ||
| danger.yml | ||
| deploy_cloudflare.yml | ||
| deploy_collab.yml | ||
| eval.yml | ||
| good_first_issue_notifier.yml | ||
| nix.yml | ||
| publish_extension_cli.yml | ||
| randomized_tests.yml | ||
| release_nightly.yml | ||
| script_checks.yml | ||
| unit_evals.yml | ||