mirror of
https://github.com/zed-industries/zed.git
synced 2026-06-01 05:51:14 +00:00
original uri https://github.com/zed-industries/zed
https://zed.dev
9affe8cbac
Fixes #49466 It looks like this wasn't actually a bug in the PHP outline query, but a general sticky scroll bug. In PHP, the attribute ends up inside the `function_declaration` as a child node, so sticky headers were previously taking their start from `item.range.start` and getting stuck on the `#[Deprecated]` line instead of `function foo()`. Switching to `source_range_for_text.start` fixes exactly that, and also covers other languages that put decorators or attributes before the declaration. I added the test in TypeScript because it has the same tree shape and covers the same class of bug as #49466 --- Before: <img width="967" height="772" alt="Screenshot from 2026-04-07 08-46-10" src="https://github.com/user-attachments/assets/a6b2aa2b-03f7-4abf-a4c4-c87d41df83ae" /> After: <img width="1245" height="993" alt="Screenshot from 2026-04-07 08-23-32" src="https://github.com/user-attachments/assets/27ef2487-d7fd-4a73-93e5-97fc719f9245" /> <img width="1245" height="993" alt="Screenshot from 2026-04-07 08-23-40" src="https://github.com/user-attachments/assets/1b1daf80-544d-4128-bc92-b7d44b8d6564" /> <img width="963" height="636" alt="Screenshot from 2026-04-07 08-23-53" src="https://github.com/user-attachments/assets/bb244ce9-797e-4a5f-b48f-eb0e4b982f7d" /> --- Tests: Nextest run ID f0de6791-1a3c-406b-9589-54df870b832b with nextest profile: default Starting 3 tests across 1 binary (655 tests skipped) PASS [ 0.986s] (1/3) editor editor_tests::test_sticky_scroll PASS [ 0.436s] (2/3) editor editor_tests::test_sticky_scroll_with_decoration_prefix_in_item PASS [ 0.822s] (3/3) editor editor_tests::test_sticky_scroll_with_expanded_deleted_diff_hunks ──────────── Summary [ 2.298s] 3 tests run: 3 passed, 655 skipped Release Notes: - Fixed sticky scroll headers showing attribute/decorator lines instead of the declaration line in PHP and other languages where annotations are child nodes of the declaration. Co-authored-by: dino <dinojoaocosta@gmail.com> |
||
|---|---|---|
| .cargo | ||
| .cloudflare | ||
| .config | ||
| .factory | ||
| .github | ||
| .zed | ||
| assets | ||
| ci | ||
| crates | ||
| docs | ||
| extensions | ||
| legal | ||
| nix | ||
| script | ||
| tooling | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .prettierrc | ||
| .rules | ||
| AGENTS.md | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CLAUDE.md | ||
| clippy.toml | ||
| CODE_OF_CONDUCT.md | ||
| codebook.toml | ||
| compose.yml | ||
| CONTRIBUTING.md | ||
| debug.plist | ||
| default.nix | ||
| Dockerfile-collab | ||
| Dockerfile-collab.dockerignore | ||
| Dockerfile-cross.dockerignore | ||
| Dockerfile-distros | ||
| Dockerfile-distros.dockerignore | ||
| flake.lock | ||
| flake.nix | ||
| GEMINI.md | ||
| LICENSE-AGPL | ||
| LICENSE-APACHE | ||
| LICENSE-GPL | ||
| livekit.yaml | ||
| lychee.toml | ||
| Procfile | ||
| Procfile.all | ||
| Procfile.web | ||
| README.md | ||
| renovate.json | ||
| REVIEWERS.conl | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| shell.nix | ||
| typos.toml | ||
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.