mirror of
https://github.com/zed-industries/zed.git
synced 2026-10-19 02:54:11 +00:00
original uri https://github.com/zed-industries/zed
https://zed.dev
7230a5acc5
## Summary Closes #65147 Fixes partially unclickable rows of wrapped links in Markdown tables, affecting Markdown previews and rendered agent responses. A detailed video of the bug, provided by issue author [@machadinhos](https://github.com/machadinhos), can be found [here](https://github-production-user-asset-6210df.s3.amazonaws.com/101654160/665208322-97183453-77c1-4364-94cf-d6f7eae85810.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20261008%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20261008T220525Z&X-Amz-Expires=300&X-Amz-Signature=c92d295ab82d512815bd9d4dc011293c3c8a2b34134781823d835d757a633f11&X-Amz-SignedHeaders=host&response-content-type=video%2Fmp4). Currently vertically centered table cells can cause hit testing to mistake a position inside a later cell for a gap between text blocks. Defer the first gap fallback until all text blocks have been checked, allowing actual text hits to take precedence. ## Testing Implemented `#[gpui::test]'s` for different table layouts and link lengths - 6f8a223669d9b8eb6c8c810c3467dbe8dea72230 - 87e2e59176f3258eb8c200749823ee68af87167e - b6456a474c5daa871ad57c08894140f157296490 - 15b581003241be0b2868a663ad56a274569cc7a3 The fix passes all 188/188 tests for the markdown crate, the previous implementation fails all newly added test cases. ```text test tests::test_wrapped_table_links_hit_testing ... ok test tests::test_wrapped_table_link_mouse_release ... ok test tests::test_wrapped_table_link_unicode_and_surrounding_text ... ok test tests::test_wrapped_table_link_column_positions_and_alignment ... ok test tests::test_wrapped_table_link_hover_click_and_resize ... ok test tests::test_copy_button_copies_commonmark_code_block_content ... ok test tests::test_wrapped_table_link_interactions_in_all_columns ... ok test result: ok. 188 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.89s ``` Build passed on **macOS** and **Windows** ## Self-review - [x] I've reviewed my diff for quality, security, reliability, and performance. - [ ] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [x] Tests cover the new or changed behavior. Release Notes: - Fixed wrapped links in Markdown tables being partially unclickable in Markdown previews and agent responses --------- Co-authored-by: MrSubidubi <finn@zed.dev> |
||
|---|---|---|
| .agents/skills | ||
| .cargo | ||
| .cloudflare | ||
| .config | ||
| .factory | ||
| .github | ||
| .wezel | ||
| .zed | ||
| assets | ||
| ci | ||
| crates | ||
| docs | ||
| extensions | ||
| legal | ||
| nix | ||
| script | ||
| tooling | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .prettierrc | ||
| .rules | ||
| AGENTS.md | ||
| Cargo.lock | ||
| Cargo.toml | ||
| CLAUDE.md | ||
| clippy.toml | ||
| CODE_OF_CONDUCT.md | ||
| compose.yml | ||
| CONTRIBUTING.md | ||
| corgi.toml | ||
| default.nix | ||
| Dockerfile-collab | ||
| Dockerfile-collab.dockerignore | ||
| Dockerfile-cross.dockerignore | ||
| Dockerfile-distros | ||
| Dockerfile-distros.dockerignore | ||
| flake.lock | ||
| flake.nix | ||
| GEMINI.md | ||
| LICENSE-APACHE | ||
| LICENSE-GPL | ||
| Procfile | ||
| Procfile.web | ||
| README.md | ||
| rust-toolchain.toml | ||
| rustfmt.toml | ||
| shell.nix | ||
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.