Finn Evers 3a1bd38503 reqwest_client: Only register proxies with valid proxy URIs (#27773) ... Closes #27641 This PR fixes invalid proxy URIs being registered despite the URI not being a valid proxy URI. Whilst investigating #27641 , I noticed that currently any proxy URI passed to `RequestClient::proxy_and_user_agent` will be assigned to the created client, even if the URI is not a valid proxy URI. Given a test as an example: We create an URI here and pass it as a proxy to `ReqwestClient::proxy_and_user_agent`: https://github.com/zed-industries/zed/blob/main/crates/reqwest_client/src/reqwest_client.rs#L272-L273 In `ReqwestClient::proxy_and_user_agent`we take the proxy parameter here 9b40770e9f/crates/reqwest_client/src/reqwest_client.rs (L46) and set it unconditionally here: 9b40770e9f/crates/reqwest_client/src/reqwest_client.rs (L62) , not considering at all whether the proxy was successfully created above. Concluding, we currently do not actually check whether a proxy was successfully created, but rather whether an URI is equal to itself, which trivially holds. The existing test for a malformed proxy URI 9b40770e9f/crates/reqwest_client/src/reqwest_client.rs (L293-L297) does not check whether invalid proxies cause an error, but rather checks whether `http::Uri::from_static` panics on an invalid URI, [which it does as documented](https://docs.rs/http/latest/http/uri/struct.Uri.html#panics). Thus, the tests currently do not really check anything proxy-related and invalid proxies are assigned as valid proxies. --- This PR fixes the behaviour by considering whether the proxy was actually properly parsed and only assigning it if that is the case. Furthermore, it improves logging in case of errors so issues like the linked one are easier to debug (for the linked issue, the log will now include that the proxy schema is not supported in the logs). Lastly, it also updates the test for a malformed proxy URI. The test now actually checks that malformed proxy URIs are not registered for the client rather than testing the `http` crate. The update also initially caused the [test for a `socks4a` proxy](9b40770e9f/crates/reqwest_client/src/reqwest_client.rs (L280C1-L282C50)) to fail. This happened because the reqwest-library introduced supports for `socks4a` proxies in [version 0.12.13](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md#v01213). Thus, this PR includes a bump of the reqwest library to add proper support for socks4a proxies. Release Notes: - Added support for socks4a proxies. --------- Co-authored-by: Peter Tripp <peter@zed.dev>		2025-04-28 11:12:16 -04:00
..
src	Add workspace-hack (#27277)	2025-04-02 13:26:34 -07:00
.gitattributes	Add workspace-hack (#27277)	2025-04-02 13:26:34 -07:00
.ignore	Add workspace-hack (#27277)	2025-04-02 13:26:34 -07:00
build.rs	Add workspace-hack (#27277)	2025-04-02 13:26:34 -07:00
Cargo.toml	reqwest_client: Only register proxies with valid proxy URIs (#27773)	2025-04-28 11:12:16 -04:00
LICENSE-GPL	Add workspace-hack (#27277)	2025-04-02 13:26:34 -07:00