mirror of
https://github.com/zed-industries/zed.git
synced 2026-06-02 07:04:33 +00:00
9a5b97db00
On X11 I was unable to type ä ü and other umlauts in files with autoclose enabled, because typing ä requires me to hit - compose key - `"` - `a` When the `"` was typed, Zed would insert a matching `"` because it had a selection around the dead-key that was inserted by the compose key. We ran into a similar issue in #7611, but in the case of the Brazilian keyboard, the `"` is the compose key so we didn't trigger the matching `"`, because we didn't have a selection yet. What this does is it fixes the issue by making the surround-selection-with-quotes-or-brackets also depend on the autoclose settings, which is didn't do before. This is a breaking change for users of a Brazilian keyboard layout in which `"` cannot be used to surround an existing selection with quotes anymore. That _might_ be a change that users notice, but I can't think of scenario for that where the user wants, say, `"` to be NOT autoclosed, but work with selections. (Example is Markdown, for which autoclose for `"` is disabled. Do we want that but allow surrounding with quotes?) So it fixes the issue and makes the behavior slightly more consistent, in my eyes. Release Notes: - Changed the behavior of surrounding selections with brackets/quotes to also depend on the auto-close settings of the language. This is a breaking change for users of a Brazilian keyboard layout in which `"` cannot be used to surround an existing selection with quotes anymore. Before: [Screencast from 2024-06-04 11-49-51.webm](https://github.com/zed-industries/zed/assets/1185253/6bf255b5-32e9-4ba7-8b46-1e49ace2ba7c) After: [Screencast from 2024-06-04 11-52-19.webm](https://github.com/zed-industries/zed/assets/1185253/3cd196fc-20ba-465f-bb54-e257f7f6d9f3) |
||
|---|---|---|
| .. | ||
| src | ||
| Cargo.toml | ||
| LICENSE-GPL | ||