mirror of
https://github.com/zed-industries/zed.git
synced 2026-08-21 06:54:45 +00:00
40f7be514d
Some checks are pending
run_tests / clippy_windows (push) Blocked by required conditions
run_tests / clippy_linux (push) Blocked by required conditions
run_tests / clippy_mac (push) Blocked by required conditions
run_tests / clippy_mac_x86_64 (push) Blocked by required conditions
run_tests / run_tests_windows (push) Blocked by required conditions
run_tests / orchestrate (push) Waiting to run
run_tests / check_style (push) Waiting to run
run_tests / check_workspace_binaries (push) Blocked by required conditions
run_tests / build_visual_tests_binary (push) Blocked by required conditions
run_tests / check_wasm (push) Blocked by required conditions
run_tests / check_dependencies (push) Blocked by required conditions
run_tests / check_docs (push) Blocked by required conditions
run_tests / check_licenses (push) Blocked by required conditions
run_tests / check_scripts (push) Blocked by required conditions
run_tests / check_postgres_and_protobuf_migrations (push) Blocked by required conditions
run_tests / extension_tests (push) Blocked by required conditions
run_tests / tests_pass (push) Blocked by required conditions
run_tests / run_tests_linux (push) Blocked by required conditions
run_tests / run_tests_mac (push) Blocked by required conditions
run_tests / miri_scheduler (push) Blocked by required conditions
run_tests / doctests (push) Blocked by required conditions
Cherry-pick of #61577 to preview ---- Closes https://github.com/zed-industries/zed/issues/62801 # Objective Fix issue https://github.com/flathub/dev.zed.Zed/issues/395 (reported against the flathub package, but as described in it, it was introduced by https://github.com/zed-industries/zed/pull/57440 ). The symptom was that when running `flatpak run dev.zed.Zed <project path>` (or some alias), then you'd get two "files" opened `--zed` and `zed-editor`, with `zed-editor` also being added to the Zed project list in the open window, which was quite annoying. ## Solution - The flatpak CLI launcher, which self-launches with potential extra arguments, now puts those arguments first rather than last. ## Testing - A simple unit test targets the helper function that adds the arguments - It also verifies that the parsed args come out as expected ## Self-Review Checklist: - [ x ] I've reviewed my own diff for quality, security, and reliability - [ x ] Unsafe blocks (if any) have justifying comments - [ x ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ x ] Tests cover the new/changed behavior - [ x ] Performance impact has been considered and is acceptable Note: I believe that other bullets than self-review and tests are not relevant, as there is no unsafe, no expected performance impact, and no UI changes. --- Release Notes: - Fixed an issue where Flatpak CLI launches would open unrelated/nonexistent files due to a bug in argument construction Co-authored-by: Kirill Bulatov <kirill@zed.dev> Co-authored-by: Jonas Lundholm Bertelsen <drixi.b@gmail.com> Co-authored-by: Kirill Bulatov <kirill@zed.dev> |
||
|---|---|---|
| .. | ||
| src | ||
| build.rs | ||
| Cargo.toml | ||
| LICENSE-GPL | ||
| README.md | ||
Cli
Testing
You can test your changes to the cli crate by first building the main zed binary:
cargo build -p zed
And then building and running the cli crate with the following parameters:
cargo run -p cli -- --zed ./target/debug/zed.exe