mirror of
https://github.com/zed-industries/zed.git
synced 2026-05-24 05:25:18 +00:00
d986344da5
PR #51415 introduced the `PlatformHeadlessRenderer` trait and `PlatformWindow::render_to_image` method in `gpui`, both gated on `#[cfg(any(test, feature = "test-support"))]`, plus corresponding impls in `gpui_macos` (`window.rs` and `metal_renderer.rs`) gated on the same cfg. A dependent crate's `cfg(test)` flag does **not** propagate to its dependencies. So when `cargo test -p gpui_macos` is run in isolation, `gpui_macos`'s own `cfg(test)` is true (its impls get compiled) but `gpui` is just a regular dependency without `test-support` enabled (the trait and method don't exist), and the build fails: ``` error[E0405]: cannot find trait `PlatformHeadlessRenderer` in crate `gpui` error[E0407]: method `render_to_image` is not a member of trait `PlatformWindow` ``` The fix is to enable `gpui/test-support` as a dev-dependency, so the feature is on exactly when `gpui_macos`'s tests are being built. This bug is latent on `main` — workspace-level `cargo test` typically pulls in `gpui/test-support` transitively from other crates, masking it. Running `cargo test -p gpui_macos` alone is what surfaces it. Release Notes: - N/A
73 lines
2.2 KiB
TOML
73 lines
2.2 KiB
TOML
[package]
|
|
name = "gpui_macos"
|
|
version = "0.1.0"
|
|
edition.workspace = true
|
|
publish.workspace = true
|
|
license = "Apache-2.0"
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[lib]
|
|
path = "src/gpui_macos.rs"
|
|
|
|
[features]
|
|
default = ["gpui/default"]
|
|
test-support = ["gpui/test-support"]
|
|
runtime_shaders = []
|
|
font-kit = ["dep:font-kit"]
|
|
screen-capture = ["gpui/screen-capture"]
|
|
|
|
[dependencies]
|
|
gpui.workspace = true
|
|
|
|
[target.'cfg(target_os = "macos")'.dependencies]
|
|
anyhow.workspace = true
|
|
async-task = "4.7"
|
|
block = "0.1"
|
|
cocoa.workspace = true
|
|
collections.workspace = true
|
|
core-foundation.workspace = true
|
|
core-foundation-sys.workspace = true
|
|
core-graphics = "0.24"
|
|
core-text = "21"
|
|
core-video.workspace = true
|
|
ctor.workspace = true
|
|
derive_more.workspace = true
|
|
dispatch2 = "0.3.1"
|
|
etagere = "0.2"
|
|
# WARNING: If you change this, you must also publish a new version of zed-font-kit to crates.io
|
|
font-kit = { git = "https://github.com/zed-industries/font-kit", rev = "94b0f28166665e8fd2f53ff6d268a14955c82269", package = "zed-font-kit", version = "0.14.1-zed", optional = true }
|
|
foreign-types = "0.5"
|
|
futures.workspace = true
|
|
image.workspace = true
|
|
itertools.workspace = true
|
|
libc.workspace = true
|
|
log.workspace = true
|
|
mach2.workspace = true
|
|
media.workspace = true
|
|
metal.workspace = true
|
|
objc.workspace = true
|
|
objc2-app-kit.workspace = true
|
|
parking_lot.workspace = true
|
|
pathfinder_geometry = "0.5"
|
|
raw-window-handle = "0.6"
|
|
semver.workspace = true
|
|
smallvec.workspace = true
|
|
strum.workspace = true
|
|
util.workspace = true
|
|
uuid.workspace = true
|
|
|
|
[target.'cfg(target_os = "macos")'.build-dependencies]
|
|
cbindgen = { version = "0.28.0", default-features = false }
|
|
gpui.workspace = true
|
|
|
|
# When this crate is itself being tested (cargo test -p gpui_macos), its own
|
|
# cfg(test) flag enables impls of test-only traits like PlatformHeadlessRenderer
|
|
# and PlatformWindow::render_to_image. Those traits/methods only exist in gpui
|
|
# when gpui's `test-support` feature is on, so we have to turn that feature on
|
|
# as a dev-dependency. The `cfg(test)` flag of a dependent crate doesn't
|
|
# propagate to its dependencies, but dev-dependencies do, so this is the
|
|
# correct way to enable the feature exactly when needed.
|
|
[target.'cfg(target_os = "macos")'.dev-dependencies]
|
|
gpui = { workspace = true, features = ["test-support"] }
|