4a1df1f7ca
Closes #60733 # Objective Markdown Preview treats a relative `path:line[:column]` destination as a literal filename. When that file does not exist, the link falls through to the system URL handler instead of opening the workspace file at the requested position. ## Solution - Recognize position suffixes on relative Markdown links. - Convert GitHub-style `#L42` fragments into the same positioned target used by `path:42`, so both forms share one resolution and opening path. - Resolve links with `workspace::path_link::possible_open_target` using the Markdown source directory. This keeps the remote-project path resolution added in #61438. - Open resolved targets with `editor::items::open_resolved_target`, including its one-based row and column handling. - Preserve valid URI schemes and fall back to the existing Markdown link behavior when no workspace target resolves. ## Testing - Extended the Markdown Preview GPUI regression test to cover relative `path:line:column`, GitHub-style `#Lline`, subfolder-relative resolution, and custom URI schemes. - `git diff --check` passes. - The focused Rust test could not start in the current macOS environment because the Rust toolchain binaries hang in the dynamic loader before Cargo runs. PR Actions are awaiting maintainer approval. ## Self-Review Checklist: - [x] I have reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed UI and icon guidelines - [x] Tests cover the new and changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed Markdown Preview links using workspace-relative paths with line and column suffixes. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com> |
||
|---|---|---|
| .. | ||
| scripts | ||
| src | ||
| Cargo.toml | ||
| LICENSE-GPL | ||
| README.md | ||
Terminal View
Design Notes
This crate is split into two conceptual halves:
- The terminal.rs file and the src/mappings/ folder, these contain the code for interacting with terminal emulator backends and maintaining the pty event loop. Some behavior in this file is constrained by terminal protocols and standards. The Zed init function is also placed here.
- Everything else. These other files integrate the
Terminalstruct created in terminal.rs into the rest of GPUI. The main entry point for GPUI is the terminal_view.rs file and the modal.rs file.
ttys are created externally, and so can fail in unexpected ways. However, GPUI currently does not have an API for models than can fail to instantiate. TerminalBuilder solves this by using Rust's type system to split tty instantiation into a 2 step process: first attempt to create the file handles with TerminalBuilder::new(), check the result, then call TerminalBuilder::subscribe(cx) from within a model context.
The TerminalView struct abstracts over failed and successful terminals, passing focus through to the associated view and allowing clients to build a terminal without worrying about errors.
Backend Boundary
terminal.rs exposes backend-neutral domain types such as terminal content, cells, modes, points, ranges, scroll commands, vi motions, hyperlinks, and search matches. UI code should depend on those types instead of importing backend-specific terminal types directly.
The current implementation is still Alacritty-backed, but the abstraction boundary keeps backend details concentrated in the terminal crate:
terminal_viewrendersTerminalContentand dispatches backend-neutral actions.- Panels and tools use terminal-domain types for mode, cursor, range, hyperlink, and search behavior.
- Backend-specific conversions stay near the terminal event loop and render snapshot code.
This keeps the user-facing terminal behavior unchanged while making future backend experiments reviewable as backend implementations instead of UI-wide refactors.
Input
There are currently many distinct paths for getting keystrokes to the terminal:
-
Terminal specific characters and bindings. Things like ctrl-a mapping to ASCII control character 1, ANSI escape codes associated with the function keys, etc. These are caught with a raw key-down handler in the element and are processed immediately. This is done with the
try_keystroke()method on Terminal -
GPU Action handlers. GPUI clobbers a few vital keys by adding bindings to them in the global context. These keys are synthesized and then dispatched through the same
try_keystroke()API as the above mappings -
IME text. When the special character mappings fail, we pass the keystroke back to GPUI to hand it to the IME system. This comes back to us in the
View::replace_text_in_range()method, and we then send that to the terminal directly, bypassingtry_keystroke(). -
Pasted text has a separate pathway.
Generally, there's a distinction between 'keystrokes that need to be mapped' and 'strings which need to be written'. I've attempted to unify these under the '.try_keystroke()' API and the .input() API (which try_keystroke uses) so we have consistent input handling across the terminal