mirror of
https://github.com/zed-industries/zed.git
synced 2026-08-24 08:24:58 +00:00
58006060d1
# Objective When an user uses the Project Panel to rename a file, it is possible to change its path too. For example, renaming `README.md` to `documents/README.md` will create the `documents/` directory, in case it doesn't yet exist. Unfortunately, even though undoing a rename operation is already supported, we were not yet considering this scenario where directories had been created specifically to support the rename. As such, when undo was used, for the scenario above, we'd end up moving `README.md` back to its original location but would leave the empty `documents/` directory behind. ## Solution Introduce two new operations and changes specifically for this use-case, `Operation::CreateDir`, `Operation::RemoveDir`, `Change::DirCreated` and `Change::DirRemoved`, which we can then batch together with the `Operation::Rename` in case directories need to be created or removed. An initial approach of just keeping the list of created directories in the `Operation::Rename` and `Change::Renamed` variants was considered but it would require all users of `Operation::Rename` to now set it, even if they don't actually need it, like the drag and paste operations. Having separate operations and change variants also makes it clearer what these are meant to be used for. Something else worth noting is that, for `Operation::CreateDir`, the directory will only be created if it doesn't yet exist, otherwise we'll ignore. Same happens for `Operation::RemoveDir`, where if the directory is not empty, we don't delete it, as it's possible for new files to have been added to the directory outside of Zed and we don't want to delete those. ## Testing Tested both manually as well as introduced a new test case – `project_panel::tests::undo::rename_with_dir_undo_redo` . ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Showcase > This section is optional. If this PR does not include a visual change or does not add a new user-facing feature, you can delete this section. - Help others understand the result of this PR by showcasing your awesome work! - If this PR includes a visual change, consider adding a screenshot, GIF, or video - A before/after comparison is very useful for changes to existing features! While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases: <details> <summary>Before</summary> https://github.com/user-attachments/assets/15384fa8-9b94-495c-8992-19eee7a8f038 </details> <details> <summary>After</summary> https://github.com/user-attachments/assets/c5be9f38-a2b4-4acc-8a1e-178161e326bb </details> --- Release Notes: - Fixed undoing a file rename leaving behind directories created by the rename. |
||
|---|---|---|
| .. | ||
| benches | ||
| src | ||
| Cargo.toml | ||
| LICENSE-GPL | ||