mirror of
https://github.com/zed-industries/zed.git
synced 2026-05-23 21:05:08 +00:00
9155bf4e17
Some checks are pending
Congratsbot / check-author (push) Waiting to run
Congratsbot / congrats (push) Blocked by required conditions
deploy_nightly_docs / deploy_docs (push) Waiting to run
run_tests / orchestrate (push) Waiting to run
run_tests / check_style (push) Waiting to run
run_tests / clippy_windows (push) Blocked by required conditions
run_tests / clippy_linux (push) Blocked by required conditions
run_tests / clippy_mac (push) Blocked by required conditions
run_tests / clippy_mac_x86_64 (push) Blocked by required conditions
run_tests / run_tests_windows (push) Blocked by required conditions
run_tests / run_tests_linux (push) Blocked by required conditions
run_tests / run_tests_mac (push) Blocked by required conditions
run_tests / doctests (push) Blocked by required conditions
run_tests / check_workspace_binaries (push) Blocked by required conditions
run_tests / build_visual_tests_binary (push) Blocked by required conditions
run_tests / check_wasm (push) Blocked by required conditions
run_tests / check_dependencies (push) Blocked by required conditions
run_tests / check_docs (push) Blocked by required conditions
run_tests / check_licenses (push) Blocked by required conditions
run_tests / check_scripts (push) Blocked by required conditions
run_tests / check_postgres_and_protobuf_migrations (push) Blocked by required conditions
run_tests / extension_tests (push) Blocked by required conditions
run_tests / tests_pass (push) Blocked by required conditions
## Summary Fixes the missing Windows icon and version resource metadata for the executable installed as `bin\zed.exe`. On Windows, the bundling process builds `cli.exe` and installs it as `bin\zed.exe`. The root `Zed.exe` already embeds the Zed Windows icon and version metadata through `crates/zed/build.rs`, but the CLI executable did not embed equivalent Windows resources. As a result, Windows integrations that discover or display Zed through `bin\zed.exe` may show a missing/default application icon. This change adds Windows resource embedding to the `cli` crate and uses the same release-channel icon selection as the main Zed executable. Fixes #51154 ## Testing - Built the Windows CLI executable: ```powershell cargo build --release --package cli --target x86_64-pc-windows-msvc --locked --offline ``` - Verified `target\x86_64-pc-windows-msvc\release\cli.exe` contains: - `FileDescription = Zed` - `ProductName = Zed` - Verified the executable displays the Zed icon in Windows Explorer. - Confirmed the Windows bundling script installs `cli.exe` as `bin\zed.exe`. - Started a full Windows bundle build and confirmed it passed license generation and progressed into executable builds. The local full bundle build could not be completed because the machine is missing the VS Spectre-mitigated C++ libraries. ## Release Notes - N/A ## Notes This change is limited to Windows executable resource metadata for the CLI binary. It does not change Zed runtime behavior. --------- Co-authored-by: John Tur <john-tur@outlook.com> |
||
|---|---|---|
| .. | ||
| resources | ||
| src | ||
| Cargo.toml | ||
| LICENSE-GPL | ||