vrr/zed

mirror of https://github.com/zed-industries/zed.git synced 2026-08-30 05:32:42 +00:00

History

Anthony Eid 7316cf7745 gpui: Report foreground executor work in bench reports (#63035 ) `BenchReport`'s frame histograms only ever recorded a window's draw and present timings, so a slow foreground task that never dirtied or drew a window was invisible to `gpui::bench` consumers even though GPUI's foreground journal already timed it. Delta hit this concretely: a foreground task stalled for 76-130ms with no window draw in progress, and the only way to see it in a benchmark was to manually queue a marker task and time it by hand, outside the normal report. GPUI already has the data needed to close this gap. The foreground journal (`crate::profiler::journal`, merged separately in #62779) times every foreground task poll, action handler, and input dispatch on the main thread, independent of whether a window ever gets involved. This PR wires that journal into `BenchAppContext`/`BenchReport` so the existing benchmark harness reports it directly, instead of asking benchmark authors to build their own timing side channel. `TraceScope`, the type that already scopes frame-timing collection to a measurement, now also owns a `ForegroundJournalCollector` created at the same point it starts. Since a collector only observes journal entries recorded after its own creation, per-iteration setup work (which runs before the trace scope starts) is excluded from the measurement by construction, the same way it already was for draw/present timings. Drained task poll, action, and input events are recorded into a new `foreground_work` duration histogram on `BenchReport` (draws and presents are skipped there since the existing frame-timing histograms already cover them), exposed through `BenchReport::foreground_work()` as `count`/`total`/`max`/percentiles plus frame-budget overruns at the report's configured FPS, and printed alongside the existing histograms. Because this rides on the same per-task-poll instrumentation that already powers GPUI's hang detection, it works for `bench_task`, `bench_batched_task`, and `bench_renderer` without requiring a window at all, and it aggregates every foreground event recorded during a measurement (not just the first). The `#[cfg(test)]`-only `install_test_foreground_journal` helper is widened from `pub(super)` to `pub(crate)` so `bench_context`'s own tests can install an isolated per-thread journal instead of sharing (and being interfered by) whatever the shared production journal on that thread happens to hold. ## Testing - `cargo test -p gpui --features bench --lib bench_context` - two new focused unit tests drive the foreground journal directly: one proves a 60ms synchronous task poll with no window is reported as foreground work with no frame events recorded; the other proves an 80ms task poll before the trace scope starts is excluded from the measured summary. A third test exercises the real public API end to end, running `BenchAppContext::bench_task` through an actual `criterion::Bencher` (via `criterion::Criterion::bench_function`) and asserting the ~20ms task shows up in `BenchReport::foreground_work()`. - `cargo nextest run -p gpui --features bench --lib profiler` - the existing foreground journal, hang detection, and frame-timing test suites still pass unchanged. - `cargo check -p benchmarks --benches` - the existing `#[gpui::bench]` consumers (`bench_iter`, `bench_renderer`) still compile against the updated `TraceScope`/`BenchReport` internals. - `cargo fmt --package gpui -- --check` and `./script/clippy -p gpui --features bench` are clean. Release Notes: - N/A		2026-08-21 19:46:11 +00:00
..
docs
examples	gpui: Add spring animations; examples (#62778 )	2026-08-17 21:43:46 +00:00
resources/windows	Enable segment heap for Zed (#54538 )	2026-04-22 16:58:55 -04:00
src	gpui: Report foreground executor work in bench reports (#63035 )	2026-08-21 19:46:11 +00:00
tests	Use serde 1.0.221 instead of serde_derive hackery (#38137 )	2025-09-14 14:01:04 +02:00
build.rs	GPUI on the web (#50228 )	2026-02-26 18:36:50 +01:00
Cargo.toml	Switch from `cargo-machete` to `cargo-shear` (#62643 )	2026-08-20 10:08:48 +00:00
LICENSE-APACHE
README.md	gpui: Document standalone app setup (#58766 )	2026-06-09 20:13:23 +00:00

README.md

Welcome to GPUI!

GPUI is a hybrid immediate and retained mode, GPU accelerated, UI framework for Rust, designed to support a wide variety of applications.

Getting Started

GPUI is still in active development as we work on the Zed code editor, and is still pre-1.0. There will often be breaking changes between versions. You'll also need to use the latest version of stable Rust. Add gpui, and optionally gpui_platform, to your Cargo.toml:

gpui = { version = "*" }
gpui_platform = { version = "*", features = ["font-kit", "wayland", "x11"] }

Everything in a standalone GPUI app starts with an Application. You can create one with gpui_platform::application(), which picks the windowing and text backends for the host OS, and kick off your application by passing a callback to Application::run(). Inside this callback, you can create a new window with App::open_window() and register your first root view.

use gpui::*;

fn main() {
    gpui_platform::application().run(|cx: &mut App| {
        // ..
    });
}

`gpui_platform`

The features on gpui_platform are platform-specific, so the list above is a safe cross-platform default. If you build for a single platform, you can trim it:

macOS — Rendering uses Metal and is always available, but glyph rasterization needs font-kit. Without it, GPUI falls back to a placeholder text system that lays text out but renders no glyphs.
```
gpui_platform = { version = "*", features = ["font-kit"] }
```
Linux / FreeBSD — enable at least one windowing backend for desktop windows: wayland, x11, or both. These features also compile the renderer and text system, so no separate text feature is needed.
```
gpui_platform = { version = "*", features = ["wayland", "x11"] }
```
Windows — no features are required. Windowing uses Win32 and text uses DirectWrite. font-kit has no effect here.

Additional Topics

Dependencies

GPUI has various system dependencies that it needs in order to work.

macOS

On macOS, GPUI uses Metal for rendering. In order to use Metal, you need to do the following:

Install Xcode from the macOS App Store, or from the Apple Developer website. Note this requires a developer account.

Ensure you launch Xcode after installing, and install the macOS components, which is the default option.

Install Xcode command line tools
```
xcode-select --install
```
Ensure that the Xcode command line tools are using your newly installed copy of Xcode:
```
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
```

The Big Picture

GPUI offers three different registers depending on your needs:

State management and communication with Entity's. Whenever you need to store application state that communicates between different parts of your application, you'll want to use GPUI's entities. Entities are owned by GPUI and are only accessible through an owned smart pointer similar to an Rc. See the app::context module for more information.
High level, declarative UI with views. All UI in GPUI starts with a view. A view is simply an Entity that can be rendered, by implementing the Render trait. At the start of each frame, GPUI will call this render method on the root view of a given window. Views build a tree of elements, lay them out and style them with a tailwind-style API, and then give them to GPUI to turn into pixels. See the div element for an all purpose swiss-army knife of rendering.
Low level, imperative UI with Elements. Elements are the building blocks of UI in GPUI, and they provide a nice wrapper around an imperative API that provides as much flexibility and control as you need. Elements have total control over how they and their child elements are rendered and can be used for making efficient views into large lists, implement custom layouting for a code editor, and anything else you can think of. See the element module for more information.

Each of these registers has one or more corresponding contexts that can be accessed from all GPUI services. This context is your main interface to GPUI, and is used extensively throughout the framework.

Other Resources

In addition to the systems above, GPUI provides a range of smaller services that are useful for building complex applications:

Actions are user-defined structs that are used for converting keystrokes into logical operations in your UI. Use this for implementing keyboard shortcuts, such as cmd-q. See the action module for more information.
Platform services, such as quit the app or open a URL are available as methods on the app::App.
An async executor that is integrated with the platform's event loop. See the executor module for more information.,
The [gpui::test] macro provides a convenient way to write tests for your GPUI applications. Tests also have their own kind of context, a TestAppContext which provides ways of simulating common platform input. See app::test_context and test modules for more details.

Currently, the best way to learn about these APIs is to read the Zed source code or drop a question in the Zed Discord. We're working on improving the documentation, creating more examples, and will be publishing more guides to GPUI on our blog.