vrr/zed
2
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-05-30 03:34:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 16

auto_update_helper: Rollback for all errors including FileNotFound (#50607)

Browse source 
We would mark `FileNotFound` as success and progress the update loop
which does not make much sense.

Release Notes:

- Do not skip update roll back in presence of FileNotFound errors on Windows.

Co-authored-by: Miguel Raz Guzman Macedo <raz@zed.dev>
This commit is contained in:
Jakub Konka 2026-03-03 17:12:51 +01:00 • committed by GitHub
parent c19cc4c51e
commit d2a71b0a69
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

27
crates/auto_update_helper/src/updater.rs
View file

@ -279,19 +279,22 @@ pub(crate) fn perform_update(app_dir: &Path, hwnd: Option<isize>, launch: bool)
unsafe { PostMessageW(hwnd, WM_JOB_UPDATED, WPARAM(0), LPARAM(0))? };
break;
}
Err(err) => {
// Check if it's a "not found" error
let io_err = err.downcast_ref::<std::io::Error>().unwrap();
if io_err.kind() == std::io::ErrorKind::NotFound {
log::warn!("File or folder not found.");
last_successful_job = Some(i);
unsafe { PostMessageW(hwnd, WM_JOB_UPDATED, WPARAM(0), LPARAM(0))? };
break;
Err(err) => match err.downcast_ref::<std::io::Error>() {
Some(io_err) => match io_err.kind() {
std::io::ErrorKind::NotFound => {
log::error!("Operation failed with file not found, aborting: {}", err);
break 'outer;
}
_ => {
log::error!("Operation failed (retrying): {}", err);
std::thread::sleep(Duration::from_millis(50));
}
},
None => {
log::error!("Operation failed with unexpected error, aborting: {}", err);
break 'outer;
}
log::error!("Operation failed: {} ({:?})", err, io_err.kind());
std::thread::sleep(Duration::from_millis(50));
}
},
}
}
}