vrr/zed
2
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-07-09 16:00:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 16

auto_update_helper: Use optional reference for dialog state

Browse source
This commit is contained in:
Richard Feldman 2026-07-08 16:50:12 -04:00
parent 76f4e879e6
commit b07d9bd417
No known key found for this signature in database
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/auto_update_helper/src/dialog.rs
View file

@ -237,12 +237,10 @@ where
// procedure can re-enter (for instance through the modal loop that `show_error` runs), and
// re-`Box::from_raw`-ing the same pointer would create a second owner aliasing a live
// allocation. The pointer is null before `WM_NCCREATE` stores it and after `WM_NCDESTROY`
// clears it, so guard against dereferencing null.
// clears it; `as_ref` turns that null case into `None` instead of dereferencing it.
let raw = unsafe { GetWindowLongPtrW(hwnd, GWLP_USERDATA) as *const RefCell<DialogInfo> };
if raw.is_null() {
return None;
}
Some(f(unsafe { &*raw }))
let data = unsafe { raw.as_ref() };
data.map(f)
}
fn get_system_ui_font_name() -> String {