vrr/zed
2
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-07-10 00:13:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

gpui_windows: Bound the WM_SETTINGCHANGE string scan

Browse source
This commit is contained in:
Richard Feldman 2026-07-06 15:42:59 -04:00
parent bc5ed027a0
commit 9de3a6f1b4
No known key found for this signature in database
1 changed files with 24 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

32
crates/gpui_windows/src/events.rs
View file

@ -14,7 +14,6 @@ use windows::{
WindowsAndMessaging::*,
},
},
core::PCWSTR,
};
use crate::*;
@ -1144,14 +1143,31 @@ impl WindowsWindowInner {
}
fn handle_system_theme_changed(&self, handle: HWND, lparam: LPARAM) -> Option<isize> {
// lParam is a pointer to a string that indicates the area containing the system parameter
// that was changed.
let parameter = PCWSTR::from_raw(lparam.0 as _);
if unsafe { !parameter.is_null() && !parameter.is_empty() }
&& let Some(parameter_string) = unsafe { parameter.to_string() }.log_err()
{
// lParam is a pointer to a NUL-terminated wide string naming the area containing the
// system parameter that was changed. It comes straight off the message queue, so bound
// how far we walk it: the value is only ever compared against "ImmersiveColorSet", and
// scanning for the terminator without a limit would let a malformed message walk us off
// the end of the buffer.
let pointer = lparam.0 as *const u16;
if pointer.is_null() {
return Some(0);
}
const MAX_UNITS: usize = 64;
let mut units = Vec::with_capacity(MAX_UNITS);
for offset in 0..MAX_UNITS {
// SAFETY: `pointer` is non-null and we advance one unit at a time only while the
// preceding unit was a non-NUL part of the string, stopping at the terminator, so we
// never read past the end of a well-formed NUL-terminated buffer.
let unit = unsafe { pointer.add(offset).read() };
if unit == 0 {
break;
}
units.push(unit);
}
if !units.is_empty() {
let parameter_string = String::from_utf16_lossy(&units);
log::info!("System settings changed: {}", parameter_string);
if parameter_string.as_str() == "ImmersiveColorSet" {
if parameter_string == "ImmersiveColorSet" {
let new_appearance = system_appearance()
.context("unable to get system appearance when handling ImmersiveColorSet")
.log_err()?;