mirror of
https://github.com/zed-industries/zed.git
synced 2026-05-23 21:05:08 +00:00
auto_update: Fix Windows installer task arguments syntax (#50464)
- The Inno Setup installer requires tasks to be specified with the `/MERGETASKS` flag instead of bare arguments. - Removed the `quicklaunchicon` task as it’s no longer relevant for modern Windows 10 and up. Ref: https://zed.dev/docs/installation#windows-1 Ref: https://documentation.help/Inno-Setup/topic_setupcmdline.htm Closes #47570. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed Windows installer task arguments syntax
This commit is contained in:
parent
8bdd78e023
commit
7bdcb61722
1 changed files with 1 additions and 2 deletions
|
|
@ -1109,8 +1109,7 @@ async fn install_release_windows(downloaded_installer: &Path) -> Result<Option<P
|
|||
let mut cmd = new_command(downloaded_installer);
|
||||
cmd.arg("/verysilent")
|
||||
.arg("/update=true")
|
||||
.arg("!desktopicon")
|
||||
.arg("!quicklaunchicon");
|
||||
.arg("/MERGETASKS=!desktopicon");
|
||||
let output = cmd.output().await?;
|
||||
anyhow::ensure!(
|
||||
output.status.success(),
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue