mirror of
https://github.com/zed-industries/zed.git
synced 2026-07-10 00:13:29 +00:00
reqwest_client: Drop stale connections with keepalives (#59929)
## Summary Tune the shared `ReqwestClient` builder so HTTP connections that have silently gone bad on a flaky network path are detected and dropped rather than reused. A stale, reused HTTP/2 connection (after a NAT/conntrack timeout, a silent reset, or a degraded path) is a common source of intermittent TLS `BadRecordMac` errors against long-lived endpoints such as `cloud.zed.dev`. The client already retries these (`HttpSend` is retryable with exponential backoff), but users still see periodic multi-second stalls and "connection error" warnings. These settings make the client probe and recycle connections instead of sending a request's first records into a connection that is already dead: - `tcp_keepalive(30s)` — surface dead TCP connections instead of reusing them. - `pool_idle_timeout(30s)` — bound how long an idle connection lingers in the pool. - `http2_keep_alive_interval(15s)` / `http2_keep_alive_timeout(10s)` / `http2_keep_alive_while_idle(true)` — ping idle HTTP/2 connections so broken ones are torn down. All three constructors (`new`, `user_agent`, `proxy_and_user_agent`) go through `builder()`, so every Zed HTTP client picks this up. ## Notes - Values are conservative; they can be tightened if stale-connection errors persist. - `tcp_keepalive_interval` is not yet available in the pinned `zed-reqwest` fork rev, so only the initial keepalive idle time is set here. ## Verification Behavior is network-dependent, so there is no deterministic test. Verified that the crate builds (`cargo check -p reqwest_client`). The change is being validated empirically against a setup that reproduces the `BadRecordMac` errors. Release Notes: - Improved resilience to intermittent network errors by detecting and dropping stale HTTP connections instead of reusing them.
This commit is contained in:
parent
c070f7c8ce
commit
485aeabff3
1 changed files with 9 additions and 0 deletions
|
|
@ -30,6 +30,15 @@ impl ReqwestClient {
|
|||
reqwest::Client::builder()
|
||||
.use_rustls_tls()
|
||||
.connect_timeout(Duration::from_secs(10))
|
||||
// Detect and drop connections that have silently gone bad on a
|
||||
// flaky path (NAT timeouts, resets) instead of reusing them. A
|
||||
// stale reused HTTP/2 connection is a common source of
|
||||
// `BadRecordMac` TLS errors against long-lived endpoints.
|
||||
.tcp_keepalive(Duration::from_secs(30))
|
||||
.pool_idle_timeout(Duration::from_secs(30))
|
||||
.http2_keep_alive_interval(Duration::from_secs(15))
|
||||
.http2_keep_alive_timeout(Duration::from_secs(10))
|
||||
.http2_keep_alive_while_idle(true)
|
||||
}
|
||||
|
||||
pub fn new() -> Self {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue