vrr/zed
2
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2026-05-26 15:44:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

Rename visual_test_runner to zed_visual_test_runner (#46171)

Browse source 
This fixes the auto-update failure by ensuring cargo-bundle picks 'zed'
as the first binary.

**Problem:** `cargo metadata` returns binaries alphabetically, so
`visual_test_runner` was coming before `zed`. When cargo-bundle looks
for the first binary to bundle (without `--bin`), it was picking
`visual_test_runner` - which doesn't exist in release builds because it
requires the `visual-tests` feature.

The previous fix (#46163) added `--bin zed` to explicitly select the
binary, but this caused cargo-bundle to use the binary name ('zed')
instead of the bundle metadata name ('Zed Nightly'), breaking
auto-updates.

**Fix:** Rename the binary to `zed_visual_test_runner` so it comes after
`zed` alphabetically. This restores the original bundle script behavior
that has worked for years.

Also reverts the `--bin zed` workaround from #46163.

Release Notes:

- N/A
This commit is contained in:
Richard Feldman 2026-01-06 13:28:58 -05:00 • committed by GitHub
parent 114bc699a8
commit 167970bcce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/src/development/macos.md
View file

@ -69,7 +69,7 @@ You must grant Screen Recording permission to your terminal:
### Running Visual Tests
```sh
cargo run -p zed --bin visual_test_runner --features visual-tests
cargo run -p zed --bin zed_visual_test_runner --features visual-tests
```
### Updating Baselines
@ -77,7 +77,7 @@ cargo run -p zed --bin visual_test_runner --features visual-tests
When UI changes are intentional, update the baseline images:
```sh
UPDATE_BASELINE=1 cargo run -p zed --bin visual_test_runner --features visual-tests
UPDATE_BASELINE=1 cargo run -p zed --bin zed_visual_test_runner --features visual-tests
```
Baseline images are stored in `crates/zed/test_fixtures/visual_tests/` and should be committed to the repository.