mirror of
https://github.com/unslothai/unsloth.git
synced 2026-08-25 16:52:26 +00:00
aa4ea7585b
All three pip scan-packages shards fail on main. Every unsuppressed finding is
a pattern false positive in a mainstream library or in our own published test
files, and each one already has an entry in the allowlist under an older
evidence hash.
The baseline key is (package, package-relative file, check, evidence_hash),
and the hash is over the matched code. Line shifts and version bumps are
absorbed, but when an upstream release edits a flagged line the hash moves and
the entry reopens for re-review. That is what happened here.
Reviewed and appended the 11 reopened findings:
- fastapi/routing.py, huggingface_hub/hf_api.py, openai/_base_client.py:
flagged as C2 beaconing. All three are ordinary loops, hf_api and
_base_client being paginators that advance until there is no next page.
- huggingface_hub/_sandbox.py: flagged as a staged dropper. This is the
Sandbox feature bootstrap, fetching sbx-server from the endpoint configured
on the HfApi client.
- IPython/core/interactiveshell.py and traitlets/config/loader.py: flagged as
downloading and executing remote code. Both are exec(compile(...)) over a
local file, which is what an interactive shell and a config loader do.
- unsloth_zoo/mlx/loader.py: __import__ over a hardcoded tuple of mlx_lm
module names, paired with mx.eval() calls that evaluate MLX arrays rather
than Python source.
- unsloth-zoo tests: a literal temporary_location="/tmp/ignored" kwarg,
compile()/exec() over codegen the test itself produced, and
__import__("math").exp inside a pytest.approx assert.
Existing entries are untouched: the diff is a single append hunk with no
deletions, and the first 203 entries are byte identical.
Verified by reproducing all three shards locally on Python 3.12, matching the
workflow pin. Before the change the shards reproduce the exact CI counts. After
it, all three exit 0 with unchanged MEDIUM counts and suppressed counts up by
exactly the number of findings each shard was failing on.
|
||
|---|---|---|
| .. | ||
| data | ||
| build_whisper_cpp.sh | ||
| check_frontend_dep_removal.py | ||
| check_new_install_scripts.py | ||
| enforce_kwargs_spacing.py | ||
| install_gemma4_mlx.sh | ||
| install_qwen3_6_mlx.sh | ||
| install_rocm_wsl_strixhalo.sh | ||
| lint_workflow_triggers.py | ||
| lockfile_supply_chain_audit.py | ||
| notebook_to_python.py | ||
| notebook_validator.py | ||
| profile_startup.py | ||
| run_ruff_format.py | ||
| scan_npm_packages.py | ||
| scan_npm_packages_baseline.json | ||
| scan_packages.py | ||
| scan_packages_baseline.json | ||
| stamp_studio_release.py | ||
| sync_allow_scripts_pins.py | ||
| uninstall.ps1 | ||
| uninstall.sh | ||
| verify_comment_only_diff.py | ||
| verify_import_hoist.py | ||