mirror of
https://github.com/unslothai/unsloth.git
synced 2026-08-16 04:13:54 +00:00
f567ae8f39
* Desktop: skip frontend rebuild during updates * Tests: tolerate rustfmt in updater UTF-8 contract * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Studio: use packaged frontend for PyPI installs * Studio: keep the packaged frontend skip off source checkouts STUDIO_LOCAL_INSTALL records where the Python package came from, not which tree setup runs out of. An editable overlay separates the two: with UNSLOTH_CI_SOURCE_OVERLAY, or in a venv left editable by an earlier --local run, the mode stays 0 while SCRIPT_DIR is a checkout whose dist is a stale build artifact rather than a release one. The skip then serves that stale dist and a source change silently never reaches the browser, which is the outcome the overlay legs of clean-machine-install-ci exist to catch. A wheel ships no top-level files, so a pyproject.toml next to studio/ marks the tree as source. Require its absence before trusting the packaged dist; site-packages installs are unaffected and still skip. Also check the Tauri branch before the packaged one in setup.ps1 so a desktop update reports the same reason it reports on POSIX. Covered by new cases in tests/sh/test_packaged_frontend_skip.sh and tests/studio/test_node_decision.ps1. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: danielhanchen <danielhanchen@gmail.com>
116 lines
6.9 KiB
PowerShell
116 lines
6.9 KiB
PowerShell
#!/usr/bin/env pwsh
|
|
# Unit test for setup.ps1's Get-NodeDecision (the isolated-Node source picker:
|
|
# system | bundled | skip). Pure helper, AST-extracted and run in-process -- no
|
|
# Node/npm/network needed. Also serves as a setup.ps1 parse/syntax gate.
|
|
# Run: pwsh -NoProfile -File tests/studio/test_node_decision.ps1
|
|
|
|
$ErrorActionPreference = "Stop"
|
|
$setupPath = [System.IO.Path]::Combine($PSScriptRoot, "..", "..", "studio", "setup.ps1")
|
|
$setupPath = (Resolve-Path $setupPath).Path
|
|
$source = Get-Content -Raw -Path $setupPath
|
|
|
|
$tokens = $null; $errors = $null
|
|
$ast = [System.Management.Automation.Language.Parser]::ParseFile($setupPath, [ref]$tokens, [ref]$errors)
|
|
if ($errors) { $errors | ForEach-Object { $_.ToString() }; throw "setup.ps1 has parse errors" }
|
|
|
|
$fn = $ast.FindAll({ param($n)
|
|
$n -is [System.Management.Automation.Language.FunctionDefinitionAst] -and $n.Name -eq "Get-NodeDecision"
|
|
}, $true)
|
|
if ($fn.Count -ne 1) { throw "expected exactly one Get-NodeDecision in setup.ps1, found $($fn.Count)" }
|
|
Invoke-Expression $fn[0].Extent.Text
|
|
|
|
|
|
$packagedFn = $ast.FindAll({ param($n)
|
|
$n -is [System.Management.Automation.Language.FunctionDefinitionAst] -and $n.Name -eq "Test-PackagedFrontend"
|
|
}, $true)
|
|
if ($packagedFn.Count -ne 1) { throw "expected exactly one Test-PackagedFrontend in setup.ps1, found $($packagedFn.Count)" }
|
|
Invoke-Expression $packagedFn[0].Extent.Text
|
|
|
|
$failures = 0
|
|
function Check($name, $cond) {
|
|
if ($cond) { Write-Host " PASS $name" }
|
|
else { Write-Host " FAIL $name" -ForegroundColor Red; $script:failures++ }
|
|
}
|
|
|
|
function D($node, $npm, $skip) { Get-NodeDecision -NodeVersion $node -NpmVersion $npm -SkipInstall $skip }
|
|
|
|
|
|
$packagedRoot = Join-Path ([System.IO.Path]::GetTempPath()) ("unsloth-packaged-frontend-" + [guid]::NewGuid())
|
|
$packagedIndex = Join-Path $packagedRoot "frontend\dist\index.html"
|
|
# The pyproject.toml beside studio/ that only a source checkout has. Absent
|
|
# below unless a case is specifically about the editable-overlay tree.
|
|
$packagedProject = Join-Path $packagedRoot "pyproject.toml"
|
|
New-Item -ItemType Directory -Force -Path (Split-Path -Parent $packagedIndex) | Out-Null
|
|
Set-Content -Path $packagedIndex -Value "<!doctype html>" -Encoding Ascii
|
|
try {
|
|
Check "PyPI install uses packaged frontend" (Test-PackagedFrontend -LocalInstall "0" -IndexPath $packagedIndex -ProjectFilePath $packagedProject)
|
|
Check "local install rebuilds frontend" (-not (Test-PackagedFrontend -LocalInstall "1" -IndexPath $packagedIndex -ProjectFilePath $packagedProject))
|
|
Check "unset install mode rebuilds frontend" (-not (Test-PackagedFrontend -LocalInstall "" -IndexPath $packagedIndex -ProjectFilePath $packagedProject))
|
|
|
|
# Editable overlay: PyPI mode over a checkout, whose dist is a stale build
|
|
# artifact rather than a release one.
|
|
Set-Content -Path $packagedProject -Value "[project]" -Encoding Ascii
|
|
Check "source checkout in PyPI mode rebuilds frontend" (-not (Test-PackagedFrontend -LocalInstall "0" -IndexPath $packagedIndex -ProjectFilePath $packagedProject))
|
|
Remove-Item -LiteralPath $packagedProject -Force
|
|
Check "packaged layout skips once no source marker remains" (Test-PackagedFrontend -LocalInstall "0" -IndexPath $packagedIndex -ProjectFilePath $packagedProject)
|
|
|
|
Remove-Item -LiteralPath $packagedIndex -Force
|
|
Check "missing packaged index rebuilds frontend" (-not (Test-PackagedFrontend -LocalInstall "0" -IndexPath $packagedIndex -ProjectFilePath $packagedProject))
|
|
} finally {
|
|
Remove-Item -LiteralPath $packagedRoot -Recurse -Force -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
Write-Host "Get-NodeDecision"
|
|
# system
|
|
Check "node22 + npm11 -> system" ((D "v22.17.1" "11.13.0" "0") -eq "system")
|
|
Check "node20.19 + npm11 -> system" ((D "v20.19.0" "11.0.0" "0") -eq "system")
|
|
Check "node24 + npm11 -> system" ((D "v24.17.0" "11.13.0" "0") -eq "system")
|
|
Check "node23 + npm11 -> system" ((D "v23.5.0" "11.0.0" "0") -eq "system")
|
|
# bundled (the reported bug: fine Node, stale npm)
|
|
Check "node22 + npm10 -> bundled" ((D "v22.17.1" "10.9.2" "0") -eq "bundled")
|
|
Check "node18 -> bundled" ((D "v18.20.0" "11.0.0" "0") -eq "bundled")
|
|
Check "node22.11 -> bundled" ((D "v22.11.0" "11.0.0" "0") -eq "bundled")
|
|
Check "node20.18 -> bundled" ((D "v20.18.0" "11.0.0" "0") -eq "bundled")
|
|
Check "node21 (odd) -> bundled" ((D "v21.7.0" "11.0.0" "0") -eq "bundled")
|
|
Check "missing -> bundled" ((D "" "" "0") -eq "bundled")
|
|
# skip flag
|
|
Check "npm10 + skip -> skip" ((D "v22.17.1" "10.9.2" "1") -eq "skip")
|
|
Check "missing + skip -> skip" ((D "" "" "1") -eq "skip")
|
|
Check "good + skip -> system" ((D "v22.17.1" "11.13.0" "1") -eq "system")
|
|
|
|
# Structural guards: OXC can need Node when frontend is skipped, custom roots
|
|
# must exist before NodeParent creation, bundled Node must isolate npm, and the
|
|
# reuse (system) arm must touch nothing -- no prefix pin, no global install.
|
|
$nodeSourceOffset = $source.IndexOf('$NodeSource = Get-NodeDecision')
|
|
$skipFrontendBranchOffset = $source.IndexOf('} elseif ($SkipFrontend) {')
|
|
$customHomeErrorOffset = $source.IndexOf('UNSLOTH_STUDIO_HOME/STUDIO_HOME=$NodeOverride does not exist')
|
|
$nodeParentMkdirOffset = $source.IndexOf('New-Item -ItemType Directory -Force -Path $NodeParent')
|
|
$npmPrefixOffset = $source.IndexOf('$env:NPM_CONFIG_PREFIX = $NodeDir')
|
|
$nodePathClearOffset = $source.IndexOf('Remove-Item Env:NODE_PATH')
|
|
$bundledBranchOffset = $source.IndexOf('} elseif ($NodeSource -eq "bundled") {')
|
|
$systemArmOffset = $source.IndexOf('$SysNodeVersion | npm $SysNpmVersion (system)')
|
|
$globalBunOffset = $source.IndexOf('npm install -g bun')
|
|
Check "NodeSource initialized before SKIP_STUDIO_FRONTEND branch" (
|
|
$nodeSourceOffset -ge 0 -and $skipFrontendBranchOffset -ge 0 -and $nodeSourceOffset -lt $skipFrontendBranchOffset
|
|
)
|
|
Check "custom Unsloth home validated before Node parent creation" (
|
|
$customHomeErrorOffset -ge 0 -and $nodeParentMkdirOffset -ge 0 -and $customHomeErrorOffset -lt $nodeParentMkdirOffset
|
|
)
|
|
Check "bundled Node pins npm prefix and clears NODE_PATH" (
|
|
$npmPrefixOffset -ge 0 -and $nodePathClearOffset -ge 0 -and $npmPrefixOffset -lt $nodePathClearOffset
|
|
)
|
|
# Symmetric to tests/sh/test_system_node_readonly.sh: the prefix pin and the only
|
|
# global install (bun) sit between the bundled-branch marker and the system arm,
|
|
# i.e. inside bundled, so reusing a good system Node mutates nothing.
|
|
Check "npm prefix pin lives in the bundled branch, not the system arm" (
|
|
$bundledBranchOffset -ge 0 -and $systemArmOffset -ge 0 -and
|
|
$bundledBranchOffset -lt $npmPrefixOffset -and $npmPrefixOffset -lt $systemArmOffset
|
|
)
|
|
Check "global bun install lives in the bundled branch, not the system arm" (
|
|
$bundledBranchOffset -ge 0 -and $systemArmOffset -ge 0 -and
|
|
$bundledBranchOffset -lt $globalBunOffset -and $globalBunOffset -lt $systemArmOffset
|
|
)
|
|
|
|
Write-Host ""
|
|
if ($failures -gt 0) { Write-Host "$failures check(s) FAILED" -ForegroundColor Red; exit 1 }
|
|
Write-Host "All checks passed" -ForegroundColor Green
|