mirror of
https://github.com/unslothai/unsloth.git
synced 2026-05-18 23:35:25 +00:00
Two gaps surfaced when running tests/test_import_fixes_drift.py on a
fresh main install (transformers 4.57.6, trl 0.25.1, peft 0.19.1,
triton 3.5.1, vllm 0.15.1):
* triton_compiled_kernel test predicate was strict: only accepted
a class-level num_ctas. fix_triton_compiled_kernel_missing_attrs
installs the attrs via a wrapped __init__ (the post-3.6 shape),
so the detector fired DRIFT DETECTED even with the fix correctly
applied. Relax to also accept the wrapped-__init__ signature
(closure freevars / co_names probe). Mirrors zoo's already-relaxed
predicate (unsloth-zoo PR #639).
* tests/conftest.py applied ONLY the peft transformers_weight_conversion
stub fix via file-path loading. fix_vllm_guided_decoding_params /
fix_triton_compiled_kernel_missing_attrs / etc. never ran inside the
test process, so the corresponding drift detectors probed an
unpatched runtime state and pytest.fail'd. Replace the surgical
file-path loader with a guarded import unsloth (the GPU-free
harness above already pre-spoofs the device-type chain), so the
full import_fixes.py pass applies before pytest collects. Mirrors
unsloth-zoo's conftest pattern.
Local verification on transformers 4.57.6 + trl 0.25.1 + peft 0.19.1
+ triton 3.5.1 + vllm 0.15.1+cu130:
before: 16 passed, 2 failed (triton + vllm DRIFT DETECTED)
after: 18 passed, 0 failed
163 lines
5.7 KiB
Python
163 lines
5.7 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved.
|
|
|
|
"""GPU-free test harness.
|
|
|
|
unsloth's import chain hits unsloth_zoo.device_type, which calls
|
|
get_device_type() at import time and raises NotImplementedError on CI
|
|
runners with no CUDA / XPU / HIP visible. Pre-load the real
|
|
unsloth_zoo.device_type under a temporarily-mocked
|
|
torch.cuda.is_available() so its @cache permanently captures "cuda".
|
|
On a real accelerator the pre-load is skipped and detection runs
|
|
normally.
|
|
|
|
Mirrors the conftest harness in unslothai/unsloth-zoo PR #624.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import os
|
|
import sys
|
|
import types
|
|
|
|
|
|
def _has_real_accelerator() -> bool:
|
|
try:
|
|
import torch
|
|
except Exception:
|
|
return False
|
|
for probe in (
|
|
lambda: hasattr(torch, "cuda") and torch.cuda.is_available(),
|
|
lambda: hasattr(torch, "xpu") and torch.xpu.is_available(),
|
|
lambda: hasattr(torch, "accelerator") and torch.accelerator.is_available(),
|
|
):
|
|
try:
|
|
if probe():
|
|
return True
|
|
except Exception:
|
|
pass
|
|
return False
|
|
|
|
|
|
def _preload_device_type(package: str, prereqs: tuple[str, ...] = ()) -> bool:
|
|
"""Pre-load <package>.device_type under a mocked
|
|
torch.cuda.is_available() == True so its @cache permanently
|
|
captures "cuda". prereqs lists submodule names of <package> that
|
|
must be loaded first (e.g. 'utils' for unsloth_zoo). Returns False
|
|
if the package or any prerequisite cannot be imported, in which
|
|
case the caller falls back to a stub."""
|
|
target = f"{package}.device_type"
|
|
if target in sys.modules:
|
|
return True
|
|
pkg_spec = importlib.util.find_spec(package)
|
|
if pkg_spec is None or not pkg_spec.submodule_search_locations:
|
|
return False
|
|
pkg_path = pkg_spec.submodule_search_locations[0]
|
|
|
|
skeleton_already = package in sys.modules
|
|
if not skeleton_already:
|
|
skel = types.ModuleType(package)
|
|
skel.__path__ = [pkg_path]
|
|
skel.__spec__ = pkg_spec
|
|
skel.__package__ = package
|
|
sys.modules[package] = skel
|
|
|
|
try:
|
|
for prereq in prereqs:
|
|
full = f"{package}.{prereq}"
|
|
if full in sys.modules:
|
|
continue
|
|
prereq_path = os.path.join(pkg_path, f"{prereq}.py")
|
|
prereq_spec = importlib.util.spec_from_file_location(full, prereq_path)
|
|
prereq_mod = importlib.util.module_from_spec(prereq_spec)
|
|
sys.modules[full] = prereq_mod
|
|
prereq_spec.loader.exec_module(prereq_mod)
|
|
|
|
device_type_path = os.path.join(pkg_path, "device_type.py")
|
|
dt_spec = importlib.util.spec_from_file_location(target, device_type_path)
|
|
dt_mod = importlib.util.module_from_spec(dt_spec)
|
|
sys.modules[target] = dt_mod
|
|
|
|
import torch
|
|
|
|
_orig_is_avail = torch.cuda.is_available
|
|
torch.cuda.is_available = lambda: True # type: ignore[assignment]
|
|
try:
|
|
dt_spec.loader.exec_module(dt_mod)
|
|
finally:
|
|
torch.cuda.is_available = _orig_is_avail
|
|
except Exception:
|
|
sys.modules.pop(target, None)
|
|
return False
|
|
finally:
|
|
if not skeleton_already:
|
|
sys.modules.pop(package, None)
|
|
|
|
return True
|
|
|
|
|
|
def _patch_torch_cuda_for_import() -> None:
|
|
"""Stub torch.cuda.* probes that fire at IMPORT time of unsloth /
|
|
unsloth_zoo when DEVICE_TYPE was forced to "cuda" above. These are
|
|
queries, not real GPU work, so returning plausible Ampere values
|
|
lets the import chain finish; tests that touch real tensors run on
|
|
CPU like normal."""
|
|
try:
|
|
import torch.cuda.memory as _cuda_memory # type: ignore
|
|
|
|
_cuda_memory.mem_get_info = lambda *a, **k: (0, 80 * 1024**3)
|
|
except Exception:
|
|
pass
|
|
try:
|
|
import torch
|
|
|
|
torch.cuda.get_device_capability = lambda *a, **k: (8, 0)
|
|
torch.cuda.is_bf16_supported = lambda *a, **k: True
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
def _install_device_type_stub(name: str) -> None:
|
|
stub = types.ModuleType(name)
|
|
stub.DEVICE_TYPE = "cuda"
|
|
stub.DEVICE_TYPE_TORCH = "cuda"
|
|
stub.DEVICE_COUNT = 1
|
|
stub.ALLOW_PREQUANTIZED_MODELS = False
|
|
stub.is_hip = lambda: False
|
|
stub.get_device_type = lambda: "cuda"
|
|
stub.get_device_count = lambda: 1
|
|
stub.device_synchronize = lambda *a, **k: None
|
|
stub.device_empty_cache = lambda *a, **k: None
|
|
stub.device_is_bf16_supported = lambda *a, **k: False
|
|
sys.modules[name] = stub
|
|
|
|
|
|
if not _has_real_accelerator():
|
|
if not _preload_device_type("unsloth_zoo", prereqs = ("utils",)):
|
|
_install_device_type_stub("unsloth_zoo.device_type")
|
|
if not _preload_device_type("unsloth"):
|
|
_install_device_type_stub("unsloth.device_type")
|
|
_patch_torch_cuda_for_import()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Apply ALL upstream-drift fixes (vllm GuidedDecodingParams alias, triton
|
|
# CompiledKernel attr wrap, peft transformers_weight_conversion stub, etc.)
|
|
# by triggering ``import unsloth``. Fixes live on ``unsloth/import_fixes.py``
|
|
# and apply at unsloth import time. The GPU-free harness above pre-spoofs
|
|
# the device-type chain so ``import unsloth`` survives on a CPU-only runner.
|
|
# Suites without unsloth installed (e.g. security-only) keep passing --
|
|
# the ImportError is swallowed and the drift detectors will surface any
|
|
# pathology the missing patches would have hidden.
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _apply_upstream_import_fixes_for_tests() -> None:
|
|
try:
|
|
import unsloth # noqa: F401 # runs unsloth/import_fixes.py
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
_apply_upstream_import_fixes_for_tests()
|