mirror of
https://github.com/unslothai/unsloth.git
synced 2026-08-25 08:42:25 +00:00
* feat(studio): add custom llama.cpp path setting * fix(studio): harden custom llama.cpp selection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix custom llama.cpp path resolution * Shorten llama cpp path comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Distinguish non-executable llama server paths * Reload after llama server path changes * Refresh llama consumers after path changes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
235 lines
9.1 KiB
Python
235 lines
9.1 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Behavioral tests for the --with-llama-cpp-dir 'unmanaged local link' contract.
|
|
|
|
When the canonical llama.cpp dir is a symlink (POSIX) / junction (Windows) to a
|
|
user's own checkout, Unsloth must treat it as externally managed:
|
|
- the in-app updater must not offer or apply a prebuilt over the link
|
|
- orphan cleanup must not kill a llama-server the user launched from that tree
|
|
|
|
These exercise real link behavior rather than grepping the scripts.
|
|
"""
|
|
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from utils import llama_cpp_path_settings as path_settings
|
|
from utils import llama_cpp_update as u
|
|
from core.inference import llama_cpp as llama_cpp_module
|
|
from core.inference.llama_cpp import LlamaCppBackend
|
|
|
|
|
|
@pytest.fixture(autouse = True)
|
|
def _no_whisper_piggyback(monkeypatch):
|
|
# Keep the whisper piggyback probe off the host: these tests exercise the
|
|
# llama local-link contract only.
|
|
monkeypatch.setattr(u, "_whisper_chain_status", lambda **kwargs: None)
|
|
|
|
|
|
def _make_link(link: Path, target: Path) -> None:
|
|
"""Create a directory junction (Windows) / symlink (POSIX); neither needs
|
|
elevation."""
|
|
target.mkdir(parents = True, exist_ok = True)
|
|
if os.name == "nt":
|
|
subprocess.run(
|
|
["cmd", "/c", "mklink", "/J", str(link), str(target)],
|
|
check = True,
|
|
capture_output = True,
|
|
text = True,
|
|
)
|
|
else:
|
|
link.symlink_to(target, target_is_directory = True)
|
|
|
|
|
|
def _server_subpath() -> Path:
|
|
return Path(
|
|
"build/bin/Release/llama-server.exe" if os.name == "nt" else "build/bin/llama-server"
|
|
)
|
|
|
|
|
|
class _FakeProc:
|
|
def __init__(self, pid: int, exe: str) -> None:
|
|
self.info = {"pid": pid, "name": "llama-server", "exe": exe}
|
|
self.killed = False
|
|
|
|
def kill(self) -> None:
|
|
self.killed = True
|
|
|
|
|
|
def test_is_external_link_detects_link_vs_plain_dir(tmp_path: Path) -> None:
|
|
plain = tmp_path / "plain"
|
|
plain.mkdir()
|
|
assert u._is_external_link(plain) is False
|
|
|
|
link = tmp_path / "link"
|
|
_make_link(link, tmp_path / "tgt")
|
|
assert u._is_external_link(link) is True
|
|
|
|
|
|
def test_active_install_is_local_link(tmp_path: Path) -> None:
|
|
link = tmp_path / "llama.cpp"
|
|
_make_link(link, tmp_path / "tgt")
|
|
binary = str(link / _server_subpath())
|
|
assert u._active_install_is_local_link(binary) is True
|
|
|
|
# A plain (non-link) llama.cpp dir is Unsloth-managed, not a local link.
|
|
plain = tmp_path / "plain" / "llama.cpp"
|
|
plain.mkdir(parents = True)
|
|
assert u._active_install_is_local_link(str(plain / _server_subpath())) is False
|
|
|
|
|
|
def test_get_update_status_reports_local_link(tmp_path: Path, monkeypatch) -> None:
|
|
link = tmp_path / "llama.cpp"
|
|
_make_link(link, tmp_path / "tgt")
|
|
monkeypatch.setattr(u, "_find_binary", lambda: str(link / _server_subpath()))
|
|
st = u.get_update_status()
|
|
assert st["supported"] is False
|
|
assert st["update_available"] is False
|
|
assert st["local_link"] is True
|
|
|
|
|
|
def test_start_update_refuses_local_link(tmp_path: Path, monkeypatch) -> None:
|
|
link = tmp_path / "llama.cpp"
|
|
_make_link(link, tmp_path / "tgt")
|
|
monkeypatch.setattr(u, "_find_binary", lambda: str(link / _server_subpath()))
|
|
res = u.start_update()
|
|
assert res["started"] is False
|
|
assert res["reason"] == "local_link"
|
|
|
|
|
|
def _fake_procfs(tmp_path: Path, fake: _FakeProc) -> Path:
|
|
"""Build a /proc-shaped tree holding a single llama-server process."""
|
|
root = tmp_path / "fake-proc"
|
|
entry = root / str(fake.info["pid"])
|
|
entry.mkdir(parents = True)
|
|
# comm sits between the first "(" and the last ")"; starttime is field 22.
|
|
filler = " ".join(["0"] * 18) # fields 4..21
|
|
(entry / "stat").write_bytes(
|
|
f"{fake.info['pid']} (llama-server) S {filler} 1000".encode("utf-8")
|
|
)
|
|
(entry / "exe").symlink_to(fake.info["exe"])
|
|
# A non-numeric sibling and a process with a different name must be ignored.
|
|
(root / "self").mkdir()
|
|
other = root / str(fake.info["pid"] + 1)
|
|
other.mkdir()
|
|
(other / "stat").write_bytes(f"1 (python3) S {filler} 1000".encode("utf-8"))
|
|
return root
|
|
|
|
|
|
def _run_orphan_scan(
|
|
monkeypatch,
|
|
studio_root: Path,
|
|
fake: _FakeProc,
|
|
scan: str = "psutil",
|
|
tmp_path: Path = None,
|
|
) -> int:
|
|
# psutil drives the cross-platform process scan; skip (rather than error) if a
|
|
# minimal test env lacks it. CI installs it so these tests actually run.
|
|
psutil = pytest.importorskip("psutil")
|
|
|
|
monkeypatch.setattr(
|
|
LlamaCppBackend,
|
|
"_resolved_studio_root_and_is_legacy",
|
|
staticmethod(lambda: (studio_root.resolve(), False)),
|
|
)
|
|
monkeypatch.setattr(LlamaCppBackend, "_reap_recorded_pid", staticmethod(lambda: 0))
|
|
|
|
# The fake is an orphan by construction, so say so instead of letting the host
|
|
# decide. _kill_orphaned_servers skips any candidate whose parent is alive, and
|
|
# _pid_parent_is_alive answers that by looking the PID up for real:
|
|
# psutil.Process(pid).ppid() then psutil.pid_exists(ppid). Nothing here stubs
|
|
# psutil.Process -- only process_iter -- so the lookup hits the actual machine.
|
|
#
|
|
# The PID is os.getpid() + 888, invented on the assumption that nothing owns it.
|
|
# On a quiet runner nothing does, NoSuchProcess comes back, the candidate is
|
|
# treated as an orphan and killed. On a busier one that PID is a real process
|
|
# with a real live parent, the candidate is skipped, and the test reports
|
|
# `assert 0 == 1` having exercised the ownership logic correctly. That is what
|
|
# it did on a staging runner while passing on the org queue for the same commit.
|
|
#
|
|
# These two tests are about OWNERSHIP -- link tree spared, real root reaped --
|
|
# and parent liveness is incidental to both, so it is pinned rather than left to
|
|
# whatever else happens to be running. test_llama_cpp_wait_for_vram_settle.py
|
|
# stubs this at every one of its call sites for the same reason; this harness
|
|
# stubbed the sibling _reap_recorded_pid and missed this one.
|
|
monkeypatch.setattr(LlamaCppBackend, "_pid_parent_is_alive", staticmethod(lambda pid: False))
|
|
|
|
if scan == "procfs":
|
|
# Linux reads /proc directly. Point it at a fixture tree and intercept the
|
|
# signal, since the fixture's pid is not a real process.
|
|
if sys.platform != "linux":
|
|
pytest.skip("the procfs scan only runs on Linux")
|
|
monkeypatch.setattr(llama_cpp_module, "_PROC_ROOT", str(_fake_procfs(tmp_path, fake)))
|
|
|
|
def _fake_kill(pid, sig):
|
|
if pid == fake.info["pid"]:
|
|
fake.kill()
|
|
return
|
|
raise ProcessLookupError(pid)
|
|
|
|
monkeypatch.setattr(os, "kill", _fake_kill)
|
|
else:
|
|
# No /proc means the psutil branch, which is what macOS and Windows take.
|
|
monkeypatch.setattr(llama_cpp_module, "_PROC_ROOT", str(studio_root / "no-such-proc"))
|
|
monkeypatch.setattr(psutil, "process_iter", lambda attrs = None: iter([fake]))
|
|
return LlamaCppBackend._kill_orphaned_servers()
|
|
|
|
|
|
@pytest.mark.parametrize("scan", ["psutil", "procfs"])
|
|
def test_orphan_cleanup_spares_local_link_tree(tmp_path: Path, monkeypatch, scan) -> None:
|
|
studio_root = tmp_path / "studio-home"
|
|
studio_root.mkdir()
|
|
external = tmp_path / "external"
|
|
(external / _server_subpath().parent).mkdir(parents = True)
|
|
(external / _server_subpath()).write_text("x")
|
|
_make_link(studio_root / "llama.cpp", external)
|
|
|
|
exe_under_link = str((external / _server_subpath()).resolve())
|
|
fake = _FakeProc(os.getpid() + 777, exe_under_link)
|
|
killed = _run_orphan_scan(monkeypatch, studio_root, fake, scan, tmp_path)
|
|
assert killed == 0
|
|
assert fake.killed is False
|
|
|
|
|
|
@pytest.mark.parametrize("scan", ["psutil", "procfs"])
|
|
def test_orphan_cleanup_kills_under_real_root(tmp_path: Path, monkeypatch, scan) -> None:
|
|
# Control: a real (non-link) managed root still gets its orphan reaped, so the
|
|
# spare-the-link test above is not a no-op.
|
|
studio_root = tmp_path / "studio-home"
|
|
bin_dir = studio_root / "llama.cpp" / _server_subpath().parent
|
|
bin_dir.mkdir(parents = True)
|
|
exe = studio_root / "llama.cpp" / _server_subpath()
|
|
exe.write_text("x")
|
|
|
|
fake = _FakeProc(os.getpid() + 888, str(exe.resolve()))
|
|
killed = _run_orphan_scan(monkeypatch, studio_root, fake, scan, tmp_path)
|
|
assert killed == 1
|
|
assert fake.killed is True
|
|
|
|
|
|
@pytest.mark.parametrize("scan", ["psutil", "procfs"])
|
|
def test_orphan_cleanup_spares_studio_selected_custom_tree(
|
|
tmp_path: Path, monkeypatch, scan
|
|
) -> None:
|
|
studio_root = tmp_path / "studio-home"
|
|
studio_root.mkdir()
|
|
custom_root = tmp_path / "user-owned-llama.cpp"
|
|
binary = custom_root / _server_subpath()
|
|
binary.parent.mkdir(parents = True)
|
|
binary.write_text("x")
|
|
monkeypatch.setattr(
|
|
path_settings,
|
|
"get_stored_custom_llama_cpp_path",
|
|
lambda: custom_root.resolve(),
|
|
)
|
|
|
|
fake = _FakeProc(os.getpid() + 999, str(binary.resolve()))
|
|
killed = _run_orphan_scan(monkeypatch, studio_root, fake, scan, tmp_path)
|
|
|
|
assert killed == 0
|
|
assert fake.killed is False
|