From 5dabfef51ec4ae3f7100d96f1af1a884bf9552db Mon Sep 17 00:00:00 2001 From: David Perov Date: Thu, 1 Oct 2026 16:00:24 +0300 Subject: [PATCH] docs: finalize v0.4.9 release review --- docs/release/review-v0.4.9.md | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/docs/release/review-v0.4.9.md b/docs/release/review-v0.4.9.md index 52a5409..f115c8f 100644 --- a/docs/release/review-v0.4.9.md +++ b/docs/release/review-v0.4.9.md @@ -17,13 +17,16 @@ ## Checks run -- `bun run check:release`: running on the versioned release tree. +- `bun run check:release`: passed locally on the versioned release commit `d1d656531be4c7e67498180751d562b757648402` (version sync, sidecars, TypeScript, Rust check, 6 hotkey smoke tests and production frontend build). - `bun test`: passed locally, 276 passed, 0 failed, 0 skipped, 39 files. -- Native workspace tests and Windows hardware microphone probe: final versioned-tree rerun pending. The approved implementation previously passed 139 native tests (0 failed, 3 ignored) and the separately invoked hardware probe. -- `bun run build:release:windows`: pending. This workstation has no private updater signing key; signed production bundles are checked in GitHub Actions using the repository secret. +- Native workspace tests: `cargo test --manifest-path src-tauri/Cargo.toml --workspace --all-targets --no-run -j 2` succeeded, then all five generated test executables ran with `--test-threads=1`: 139 passed, 0 failed, 3 ignored. The isolated Windows exception parent test passed and exercised its ignored child. The hardware test was run separately; the NLLB integration test remains unrun because `TALKIS_NLLB_TEST_MODEL` is unavailable. +- Windows hardware probe: `TALKIS_RECORDER_IDLE_TEST_SECONDS=60`, exact `native_voice_recorder::windows_smoke::windows_microphone_restarts_after_idle_and_device_error` test with `--ignored --nocapture --test-threads=1`: 1 passed, 0 failed, 0 ignored; real default/selected-device restarts, pause/resume, unavailable-device recovery, injected callback failure and recording after 60-second idle all passed. Audio stays in memory; no transcription service is contacted. +- Windows build/test environment: static MSVC runtime (`RUSTFLAGS=-C target-feature=+crt-static`, `TRANSCRIBE_CMAKE_ARGS=-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded`); native compilation limited to 2 jobs, tests sequential. +- `bun run build:release:windows`: Talkis, sidecars and `Talkis_0.4.9_x64-setup.exe` built successfully; the command exited 1 only at updater signing because this workstation has no private signing key. GitHub builds signed bundles using the repository secret. +- `bun run verify:windows-release`: passed for the process cleanup hook, Talkis, all four bundled sidecars and the new NSIS installer; the application reports file/product version 0.4.9. - `bun run build:release:macos` / `bun run build:release:linux`: unavailable on the Windows workstation; native platform builds are required in Release Preflight. -- GitHub Release Preflight: pending for the release branch; macOS, Windows and Linux must pass on the exact tag commit. -- Additional manual checks: Windows 11 microphone default/selected-device restarts, pause/resume, unavailable-device recovery, injected callback failure and 60-second idle probe passed on the approved implementation. Development startup registered the tray and global shortcuts; recording logs confirm native start/stop and silence rejection. +- GitHub Release Preflight: implementation and versioned release tree passed native macOS, Windows and Linux build/packaging checks in [run 36859505925](https://github.com/SerTimBerrners-Lee/talkis/actions/runs/36859505925). The final review-only revision must repeat the three required checks before merge/tag; its results are available in [PR #21 checks](https://github.com/SerTimBerrners-Lee/talkis/pull/21/checks). +- Additional manual checks: versioned-tree hardware checks above passed on Windows 11. Development startup registered the tray and global shortcuts; recording logs confirm native start/stop and silence rejection. `git diff --check` passed. ## Manual review @@ -35,13 +38,13 @@ ## Findings -- Blockers: release gates are still pending; main and tag must not be pushed until final local checks and all three exact-commit preflight checks succeed. +- Blockers: none in the reviewed implementation. Main and tag remain gated on all three successful preflight checks for the final review revision. - Non-blocking issues: the customer's complete process exit on Windows 10 after sleep has not been reproduced; this host runs Windows 11. Actual sleep/hibernate and physical unplug were not tested. Mid-session call/live-translation reconnection is outside this change. These limits were disclosed before the user's release approval. - Native test harness: on this workstation the generated test executables need the existing Talkis Common Controls v6 manifest embedded with the Windows SDK `mt.exe` before execution; production packaging already embeds the manifest. Only ignored build artifacts are adjusted. - Follow-ups after release: verify the affected Windows 10 sleep/resume scenario and inspect the new crash log if the exit recurs. Beads CLI/workspace is unavailable on this workstation, so Beads task updates/sync could not be performed; no alternate tracker was created. ## Decision -- Ready for `main` merge: no, pending final local checks and release preflight. -- Release preflight green on exact tag commit: no, pending. -- Ready for tag publish: no, pending the mandatory gates. +- Ready for `main` merge: yes, after the final review-only revision receives all three required preflight checks. The user approved review, commit, merge and release after the Windows 10 verification limit was disclosed. +- Release preflight green on exact tag commit: mandatory; the final revision's check-runs in PR #21 must show `Preflight macos`, `Preflight windows` and `Preflight linux` successful before tagging. +- Ready for tag publish: yes, after the exact-commit preflight gate succeeds and main points to that same commit. Use fast-forward merge to preserve the verified SHA.