superpowers/tests
Jesse Vincent 99f9f00869 fix(sdd): reject empty or non-descendant BASE..HEAD ranges in review-package
When an SDD implementer commits to the wrong branch (#2050), the
BASE..HEAD range handed to review-package is either empty or not rooted
at BASE. Both cases previously produced a review package silently —
an empty one lets the reviewer approve "clean" work that isn't there.

Add two mechanical guards after BASE/HEAD validation, exiting 3 (vs 2
for usage errors) so callers can distinguish range problems:

- git merge-base --is-ancestor BASE HEAD, else "HEAD is not a
  descendant of BASE"
- git rev-list --count BASE..HEAD > 0, else "empty commit range"

Guard shape credits the analysis in closed PR #2082 by @stantheman0128.

Fixes #2050
2026-08-13 00:29:29 +00:00
..
antigravity test: realign antigravity + pi mapping assertions with pruned references 2026-07-15 11:10:55 -07:00
brainstorm-server test(deps): bump ws to ^8.21.0 in brainstorm-server tests 2026-06-18 15:44:22 -07:00
claude-code fix(sdd): reject empty or non-descendant BASE..HEAD ranges in review-package 2026-08-13 00:29:29 +00:00
codex fix(codex): make package script and its test portable beyond macOS/bsdtar 2026-07-19 12:04:46 -07:00
codex-plugin-sync fix: exclude repo metadata from Codex sync (PRI-1168) 2026-06-16 17:02:33 -07:00
devin Drop devin-tools.md — not needed for correct operation 2026-08-07 12:47:29 -07:00
explicit-skill-requests Tighten cross-platform tool references 2026-06-16 10:09:43 -07:00
hermes test(hermes): realign suite with the pre_llm_call mechanism; slim docs to the README section 2026-07-23 16:05:54 -07:00
hooks fix(hooks): dispatch the SessionStart hook via Git Bash on Windows 2026-07-19 12:03:59 -07:00
kimi Tighten Kimi plugin porting coverage 2026-06-16 10:09:44 -07:00
opencode Tighten cross-platform tool references 2026-06-16 10:09:43 -07:00
pi test(pi): scope mapping assertions to the table, not whole file 2026-07-15 11:10:55 -07:00
shell-lint Add shell lint script 2026-06-16 10:09:45 -07:00
systematic-debugging fix(systematic-debugging): find-polluter accepts ./-prefixed patterns and matches top-level tests 2026-07-23 10:54:50 -07:00
version-bump fix(release): wire Hermes into version bumps 2026-08-06 16:21:12 -07:00
writing-skills test(writing-skills): cover render-graphs execution 2026-08-05 22:38:40 -07:00