mirror of
https://github.com/supermemoryai/supermemory.git
synced 2026-05-17 12:20:04 +00:00
Some checks failed
Publish Memory Graph / publish (push) Has been cancelled
## Summary Addresses user feedback about the graph view: content in node popovers was hard-truncated at 100 characters with no way to read the full text or navigate to the document. ### Changes **Scrollable popover content (no more truncation)** - Removed the `truncate(content, 100)` call -- full content is now rendered in the popover - Made the content area scrollable with `maxHeight: 100px` and `overflowY: auto` - Increased version timeline entry truncation from 60 to 120 characters - Increased version timeline container height from 120px to 160px **"View document" in shortcuts panel** - Added an eye icon + "View document" entry to the shortcuts panel (alongside existing arrow navigation) - Clicking opens the Document Modal for the corresponding document - Works for both document nodes (opens that document) and memory nodes (opens the parent document) - Popover is automatically dismissed before the modal opens (prevents z-index overlap) - Wired `onOpenDocument` callback through the full component chain: `page.tsx` -> `GraphLayoutView` -> `MemoryGraph` wrapper -> `MemoryGraphBase` -> `NodeHoverPopover` **Shortcuts panel visual cleanup** - Icon badges (`KeyBadge`) retain dark background and border for a keyboard-key badge look - All icons (including the new EyeIcon) are uniformly wrapped in `KeyBadge` for consistent styling - Removed background, border, and border-radius from the shortcuts panel container itself - Widened shortcuts panel from 100px to 160px so navigation labels are fully visible **Type safety improvement** - Changed `MemoryGraphProps.colors` from `GraphThemeColors` to `Partial<GraphThemeColors>` to match actual usage (callers pass partial overrides that get merged with defaults) - Replaced `as Partial<typeof import(...)>` cast with proper `satisfies Partial<GraphThemeColors>` using a direct type import ### Files changed - `packages/memory-graph/src/components/node-hover-popover.tsx` -- scrollable content, EyeIcon + "View document" in shortcuts, KeyBadge styling, NavButton icon type broadened to `React.ReactNode`, all icons wrapped in KeyBadge - `packages/memory-graph/src/components/memory-graph.tsx` -- popover dismissal wrapper (`handleOpenDocument`), prop forwarding - `packages/memory-graph/src/types.ts` -- `onOpenDocument` prop on `MemoryGraphProps`, `colors` changed to `Partial<GraphThemeColors>` - `apps/web/components/graph-layout-view.tsx` -- accepts and passes `onOpenDocument` - `apps/web/components/memory-graph/memory-graph-wrapper.tsx` -- `onOpenDocument` in wrapper props, clean type import - `apps/web/app/(app)/page.tsx` -- `handleOpenDocumentById` handler, wired to `GraphLayoutView` ## Testing ### Unit Tests (154/154 passed) - **Command:** `cd packages/memory-graph && bun run test` - **Result:** 9 test files, 154 tests passed (107 existing + 47 new) - **New test file:** `packages/memory-graph/src/__tests__/node-hover-popover.test.tsx` covering: - Layout constants (`SHORTCUTS_W=160`, `CARD_W=280`, `TOTAL_W` formula) - Content area scrollability (`maxHeight:100`, `overflowY:auto`, `flex:1 1 auto`, no truncation) - KeyBadge styles (has `backgroundColor: colors.controlBg`, has `border` with `colors.controlBorder`) - Shortcuts panel styles (no `backgroundColor`, no `border`, no `borderRadius`) - EyeIcon SVG component (`aria-hidden`, viewBox, path, circle, stroke) - "View document" button render guard (`onOpenDocument && documentId`) - `documentId` derivation (memory vs document node) - VersionTimeline truncation limit (120 chars) and container maxHeight (160) - `onOpenDocument` prop wiring - NavButton icon prop type (`React.ReactNode`), all icons wrapped in KeyBadge - `handleOpenDocument` wrapper in MemoryGraph (dismiss calls, ordering, useCallback deps) ### Build - **Command:** `bun run --filter=@supermemory/memory-graph build` - **Result:** Build succeeds, 0 errors ### Lint/Format - **Command:** `bunx biome ci --changed --since=origin/main --no-errors-on-unmatched` - **Result:** 6 files checked, no fixes applied, 0 errors ### Type Checking - `packages/memory-graph`: 0 errors - `apps/web`: 0 new errors introduced ### CI - "CI - Type Check, Format & Lint" workflow passes - "Claude Code Review" workflow fails due to repo config (`non-human actor: vorflux` not in `allowed_bots` list) -- not related to code changes --- **Session Details** - Session: [View Session](https://supermemory.us1.vorflux.com/agent-sessions/d0c067f1-38c1-40c5-ada9-b2ffb7331d1c) - Requested by: Mahesh Sanikommu (mahesh@supermemory.com) - Address comments on this PR. Add `(aside)` to your comment to have me ignore it.
86 lines
2.3 KiB
TypeScript
86 lines
2.3 KiB
TypeScript
"use client"
|
|
|
|
import { memo, useCallback, useRef } from "react"
|
|
import { useQueryState } from "nuqs"
|
|
import Image from "next/image"
|
|
import { Share2 } from "lucide-react"
|
|
import { MemoryGraph } from "./memory-graph"
|
|
import { useProject } from "@/stores"
|
|
import { useGraphHighlights } from "@/stores/highlights"
|
|
import { Button } from "@ui/components/button"
|
|
import { cn } from "@lib/utils"
|
|
import { dmSansClassName } from "@/lib/fonts"
|
|
import { ShareModal } from "./share-modal"
|
|
import { shareParam } from "@/lib/search-params"
|
|
|
|
export const GraphLayoutView = memo(function GraphLayoutView({
|
|
onOpenDocument,
|
|
}: {
|
|
onOpenDocument?: (documentId: string) => void
|
|
}) {
|
|
const { effectiveContainerTags } = useProject()
|
|
const { documentIds: allHighlightDocumentIds } = useGraphHighlights()
|
|
const [isShareModalOpen, setIsShareModalOpen] = useQueryState(
|
|
"share",
|
|
shareParam,
|
|
)
|
|
const canvasRef = useRef<HTMLCanvasElement>(null)
|
|
|
|
const handleShare = useCallback(() => {
|
|
setIsShareModalOpen(true)
|
|
}, [setIsShareModalOpen])
|
|
|
|
const handleCloseShareModal = useCallback(() => {
|
|
setIsShareModalOpen(false)
|
|
}, [setIsShareModalOpen])
|
|
|
|
return (
|
|
<div className="relative h-full min-h-[calc(100dvh-8.5rem)] w-full md:min-h-0">
|
|
{/* Full-width graph */}
|
|
<div className="absolute inset-0">
|
|
<MemoryGraph
|
|
containerTags={effectiveContainerTags}
|
|
variant="consumer"
|
|
highlightDocumentIds={allHighlightDocumentIds}
|
|
highlightsVisible
|
|
maxNodes={undefined}
|
|
canvasRef={canvasRef}
|
|
onOpenDocument={onOpenDocument}
|
|
/>
|
|
</div>
|
|
|
|
{/* Share graph button - top left */}
|
|
<div className="absolute left-3 top-3 z-15 md:left-4 md:top-4">
|
|
<Button
|
|
variant="headers"
|
|
className={cn(
|
|
"size-10 rounded-full p-0 md:size-auto md:h-10! md:px-4",
|
|
"md:gap-2 md:text-base",
|
|
dmSansClassName(),
|
|
)}
|
|
onClick={handleShare}
|
|
aria-label="Share graph"
|
|
>
|
|
<Image
|
|
src="/icons/share-graph.svg"
|
|
alt="Share"
|
|
width={16}
|
|
height={16}
|
|
className="hidden md:block"
|
|
/>
|
|
<Share2 className="size-4 md:hidden" />
|
|
<span className="hidden md:inline">Share graph</span>
|
|
</Button>
|
|
</div>
|
|
|
|
{/* Share modal */}
|
|
<ShareModal
|
|
isOpen={isShareModalOpen}
|
|
onClose={handleCloseShareModal}
|
|
graphCanvasRef={canvasRef}
|
|
/>
|
|
</div>
|
|
)
|
|
})
|
|
|
|
GraphLayoutView.displayName = "GraphLayoutView"
|