From 1af0b7d967d7d7f6e437b369f933da9e8e88ecc1 Mon Sep 17 00:00:00 2001 From: fyzanshaik Date: Mon, 29 Jul 2024 18:55:07 +0530 Subject: [PATCH 1/3] Fix: Disable GitHub shortcuts in text field --- apps/extension/content/ContentApp.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/apps/extension/content/ContentApp.tsx b/apps/extension/content/ContentApp.tsx index c0339897..a8740f25 100644 --- a/apps/extension/content/ContentApp.tsx +++ b/apps/extension/content/ContentApp.tsx @@ -131,6 +131,13 @@ export default function ContentApp({ }); } }); + const handleKeyDown = (e: KeyboardEvent) => { + if (isPopoverOpen) { + e.stopPropagation(); + e.preventDefault(); + } + }; + document.addEventListener('keydown', handleKeyDown, true); const portalDiv = document.createElement("div"); portalDiv.id = "popover-portal"; From 4a90134f342f5fdc839feb8ce57cb85ca7226edb Mon Sep 17 00:00:00 2001 From: fyzanshaik Date: Mon, 29 Jul 2024 18:59:26 +0530 Subject: [PATCH 2/3] Fix: Remove event listener through cleanup --- apps/extension/content/ContentApp.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/extension/content/ContentApp.tsx b/apps/extension/content/ContentApp.tsx index a8740f25..e674137a 100644 --- a/apps/extension/content/ContentApp.tsx +++ b/apps/extension/content/ContentApp.tsx @@ -146,8 +146,10 @@ export default function ContentApp({ return () => { document.removeEventListener("mousemove", () => {}); + document.removeEventListener('keydown', handleKeyDown, true); + }; - }, []); + }, [isPopoverOpen]); const getSpaces = async () => { const response = await fetch(`${BACKEND_URL}/api/spaces`, { From 0ff4455490b9b4ed4c55297e727007a6063170c7 Mon Sep 17 00:00:00 2001 From: fyzanshaik Date: Mon, 29 Jul 2024 22:21:39 +0530 Subject: [PATCH 3/3] dependency array removed --- apps/extension/content/ContentApp.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/extension/content/ContentApp.tsx b/apps/extension/content/ContentApp.tsx index e674137a..8454eb8c 100644 --- a/apps/extension/content/ContentApp.tsx +++ b/apps/extension/content/ContentApp.tsx @@ -149,7 +149,7 @@ export default function ContentApp({ document.removeEventListener('keydown', handleKeyDown, true); }; - }, [isPopoverOpen]); + }, []); const getSpaces = async () => { const response = await fetch(`${BACKEND_URL}/api/spaces`, {