spawn/packages
A 6ee0bbed77
test: fix always-pass and try/catch anti-patterns in test suite (#1962)
- manifest-helpers.test.ts: 7 tests used try/catch where the catch block
  held all assertions. Since loadManifest() loads the local manifest.json
  when NODE_ENV is not "test", these tests passed silently with 0 assertions.
  Fix: set NODE_ENV=test + call _resetCacheForTesting() in beforeEach, and
  replace try/catch with expect(...).rejects.toThrow(). Also remove `any`
  type annotations on agentKeys/cloudKeys helper manifests.

- security-edge-cases.test.ts: "should use custom field name in error messages"
  used a manual guard (throw new Error in try) instead of expect().toThrow().
  Replace with 2 clean expect(() => ...).toThrow() calls.

- prompt-file-security.test.ts + security.test.ts: tests that checked multiple
  error message properties used try/catch with `catch (e: any)`. Replace with
  proper instanceof narrowing so the caught value is typed without `any`.

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-26 16:16:04 -05:00
..
cli test: fix always-pass and try/catch anti-patterns in test suite (#1962) 2026-02-26 16:16:04 -05:00
shared fix: remove unused biome-ignore suppression comments in shared type-guards (#1892) 2026-02-24 17:48:10 -05:00