A 41adfbdb0a test: Remove duplicate and theatrical tests (#2054) ... * test: Remove duplicate and theatrical tests - check-entity.test.ts: Remove 'kind parameter consistency' describe block (9 tests) that fully duplicated coverage already provided by 'valid entities', 'wrong-type detection: cloud given as agent', and 'wrong-type detection: agent given as cloud' describes. Also remove redundant loop assertions ('should return true for all three agent keys' etc.) that repeated what the individual named tests already covered. - manifest-cache-lifecycle.test.ts: Replace Record<string, any> with Record<string, AgentDef> and Record<string, CloudDef> for type safety. 1401 tests pass, 0 fail. Lint clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: remove extra blank line to pass Biome format check Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: Remove duplicate and theatrical tests Remove redundant if-guards around always-present agent metadata fields in manifest-type-contracts.test.ts. All 12 metadata fields (creator, repo, license, created, added, github_stars, stars_updated, language, runtime, category, tagline, tags) are present on all 7 agents, making the if (agent.X !== undefined) guards always-truthy dead code that misleads readers into thinking tests might be skipped. Restructure into proper per-agent describe blocks to make the test structure honest and clear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: Apply Biome formatting to array literal Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: Remove duplicate and theatrical tests Fix always-pass anti-pattern in manifest-type-contracts.test.ts where optional field type tests were gated by `if (field !== undefined)` OUTSIDE the `it()` block. When no agent/cloud had the field, zero tests registered, giving false confidence. Changes: - Agent optional field types: move condition inside `it()`, test always runs - Cloud optional field types: same fix, tests always register for all clouds - Interactive prompts structure: consolidate filtered loop into one `it()` that iterates internally, avoiding silently-absent test registrations - Config files structure: same consolidation pattern Before: 551 pass, 64 fail (optional field tests only registered per-agent) After: 566 pass, 64 fail (optional field tests register for every agent/cloud) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: fix biome lint errors - add block statements to early returns Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * style: apply biome formatter to block statements Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: spawn-qa-bot <qa@openrouter.ai> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: L <6723574+louisgv@users.noreply.github.com>		2026-03-01 04:16:05 -05:00
..
cli	test: Remove duplicate and theatrical tests (#2054)	2026-03-01 04:16:05 -05:00
shared	feat!: remove Fly.io cloud provider support (#1979)	2026-02-27 00:06:32 -05:00