mirror of
https://github.com/OpenRouterTeam/spawn.git
synced 2026-05-08 18:39:50 +00:00
fix: stop QA bots from creating draft PRs (#1994)
QA bots (quality, fixtures) were creating PRs as drafts but never marking them ready with `gh pr ready`. This caused the security bot to close them as "stale drafts" — even when they were fresh and contained valid work (e.g. PR #1974, closed at 2 hours old). The fix is simple: don't create drafts. QA bots already run tests before opening PRs, so the draft→ready dance is unnecessary. The security bot reviews and merges non-draft PRs directly. Changed files: - qa-quality-prompt.md: all 4 teammates now open non-draft PRs; safety rule updated to explain why - qa-fixtures-prompt.md: removed --draft flag from gh pr create Co-authored-by: spawn-bot <spawn-bot@openrouter.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
parent
f49cd97cdf
commit
df4eadd267
2 changed files with 7 additions and 7 deletions
|
|
@ -95,10 +95,10 @@ done
|
|||
|
||||
1. `git add fixtures/`
|
||||
2. Commit with message: `test: Update API fixtures for {clouds}`
|
||||
3. Push and open draft PR:
|
||||
3. Push and open a PR (NOT draft — the security bot reviews and merges non-draft PRs):
|
||||
```bash
|
||||
git push -u origin qa/fixtures
|
||||
gh pr create --draft --title "test: Update API fixtures" --body "$(cat <<'EOF'
|
||||
gh pr create --title "test: Update API fixtures" --body "$(cat <<'EOF'
|
||||
## Summary
|
||||
- Updated API fixtures for: {cloud list}
|
||||
- Skipped (no credentials): {skipped list}
|
||||
|
|
|
|||
|
|
@ -45,7 +45,7 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
|
|||
- If tests still fail after 2 fix attempts, report the failures without further attempts
|
||||
5. Run `bash -n` on all `.sh` files that were recently modified (use `git log --since="7 days ago" --name-only -- '*.sh'`)
|
||||
6. Report: total tests, passed, failed, fixed count
|
||||
7. If changes were made: commit, push, open draft PR with title "fix: Fix failing tests" and body explaining what was fixed
|
||||
7. If changes were made: commit, push, open a PR (NOT draft) with title "fix: Fix failing tests" and body explaining what was fixed
|
||||
8. Clean up worktree when done
|
||||
9. **SIGN-OFF**: `-- qa/test-runner`
|
||||
|
||||
|
|
@ -80,7 +80,7 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
|
|||
|
||||
4. For each finding: fix it (consolidate, rewrite, or remove)
|
||||
5. Run `bun test` to verify no regressions
|
||||
6. If changes were made: commit, push, open draft PR with title "test: Remove duplicate and theatrical tests"
|
||||
6. If changes were made: commit, push, open a PR (NOT draft) with title "test: Remove duplicate and theatrical tests"
|
||||
7. Clean up worktree when done
|
||||
8. Report: duplicates found, tests removed, tests rewritten
|
||||
9. **SIGN-OFF**: `-- qa/dedup-scanner`
|
||||
|
|
@ -115,7 +115,7 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
|
|||
4. For each finding: fix it
|
||||
5. Run `bash -n` on every modified `.sh` file
|
||||
6. Run `bun test` to verify no regressions
|
||||
7. If changes were made: commit, push, open draft PR with title "refactor: Remove dead code and stale references"
|
||||
7. If changes were made: commit, push, open a PR (NOT draft) with title "refactor: Remove dead code and stale references"
|
||||
8. Clean up worktree when done
|
||||
9. Report: issues found by category, files modified
|
||||
10. **SIGN-OFF**: `-- qa/code-quality`
|
||||
|
|
@ -163,7 +163,7 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
|
|||
- `sh/e2e/lib/cleanup.sh` — stale instance detection
|
||||
7. Run `bash -n` on every modified `.sh` file
|
||||
8. Re-run the E2E suite for the failed agent(s) only: `./sh/e2e/aws-e2e.sh AGENT_NAME`
|
||||
9. If changes were made: commit, push, open draft PR with title "fix(e2e): [description]"
|
||||
9. If changes were made: commit, push, open a PR (NOT draft) with title "fix(e2e): [description]"
|
||||
10. Clean up worktree when done
|
||||
11. Report: agents tested, passed, failed, fixed
|
||||
12. **SIGN-OFF**: `-- qa/e2e-tester`
|
||||
|
|
@ -225,7 +225,7 @@ You use **spawn teams**. Messages arrive AUTOMATICALLY. Do NOT poll for messages
|
|||
## Safety
|
||||
|
||||
- Always use worktrees for all work
|
||||
- NEVER commit directly to main — always open draft PRs
|
||||
- NEVER commit directly to main — always open PRs (do NOT use `--draft` — the security bot reviews and merges non-draft PRs; draft PRs get closed as stale)
|
||||
- Run `bash -n` on every modified `.sh` file before committing
|
||||
- Run `bun test` before opening any PR
|
||||
- Limit to at most 4 concurrent teammates
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue