vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-04-28 11:59:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(qa): add shutdown timeout and e2e-tester responsiveness to prevent infinite loop (#3134)
Some checks are pending
CLI Release / Build and release CLI (push) Waiting to run
Details
Lint / ShellCheck (push) Waiting to run
Details
Lint / Biome Lint (push) Waiting to run
Details
Lint / macOS Compatibility (push) Waiting to run
Details

Browse source 
When the e2e-tester finishes work and goes idle without responding to
shutdown_request, the team lead retries indefinitely burning the entire
85-min budget in a shutdown loop.

Three fixes:
1. e2e-tester protocol: add explicit instruction to respond to
   shutdown_request immediately after reporting results
2. Step 4 shutdown sequence: add 60s timeout — if a teammate doesn't
   respond, proceed with TeamDelete anyway
3. Fix stale timeout reference (25/29/30 → 75/83/85 min)

Fixes #3093

Agent: issue-fixer

Co-authored-by: B <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
A 2026-03-31 23:43:09 -07:00 • committed by GitHub
parent 1599444517
commit cd9d12d2c4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
.claude/skills/setup-agent-team/qa-quality-prompt.md
View file

@ -166,7 +166,8 @@ cd REPO_ROOT_PLACEHOLDER && git worktree remove WORKTREE_BASE_PLACEHOLDER/TASK_N
9. If changes were made: commit, push, open a PR (NOT draft) with title "fix(e2e): [description]"
10. Clean up worktree when done
11. Report: clouds tested, clouds skipped, agents passed, agents failed, fixed
12. **SIGN-OFF**: `-- qa/e2e-tester`
12. **SHUTDOWN RESPONSIVENESS**: After reporting results, remain actively responsive. If you receive a `shutdown_request` message at any point, immediately respond with `{"type":"shutdown_response","request_id":"<id>","approve":true}` — do NOT go idle without responding to a pending shutdown request.
13. **SIGN-OFF**: `-- qa/e2e-tester`
### Teammate 5: record-keeper (model=sonnet)
@ -245,7 +246,7 @@ Use the Task tool to spawn all 5 teammates in parallel:
Keep looping until:
- All tasks are completed OR
- Time budget is reached (see timeout warnings at 25/29/30 min)
- Time budget is reached (see timeout warnings at 75/83/85 min)
## Step 4 — Summary
@ -277,7 +278,13 @@ After all teammates finish, compile a summary:
- PRs: [links if any, or "none — no updates needed"]
```
Then shutdown all teammates and exit.
Then shutdown all teammates and exit:
1. Send `shutdown_request` to each teammate via `SendMessage`.
2. Wait up to 60 seconds for `shutdown_response` from each teammate.
3. **If any teammate does NOT respond within 60 seconds, consider them shut down and proceed anyway.** Do NOT retry `shutdown_request` — the teammate has completed their work and gone idle.
4. Call `TeamDelete` once all teammates have responded OR 60 seconds have elapsed.
5. **After `TeamDelete`, output the summary as plain text with NO further tool calls.** Any tool call after `TeamDelete` causes an infinite shutdown prompt loop in non-interactive mode.
## Team Coordination